How do I add yaffs file system to mainline?
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at http://github.com/cdhmanning/linux-yaffs-integration/
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?
Regards
Charles
Quoted 6 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at http://github.com/cdhmanning/linux-yaffs-integration/
It's difficult to review & comment on a git tree.
We prefer patches via email for review.
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?
Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the drivers/staging/ area.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 13 lines · On Friday 29 October 2010 06:26:41 Randy Dunlap wrote:
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.
Quoted 7 lines
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.
Hi Randy
Thanks for the response.
At this stage I'm hoping for some high level feedback about code layout etc. and don't expect an immediate approval. I expect to do some further code cleansing before getting a green light.
We're talking around 15k lines of code. Is a huge patch set the right way?
I thought it would be more polite to invite people to look at git, rather
than filling everyone's inboxes.
If you do think I should send a patch set then should I send it to lkml or fsdevel?
Thanks
Charles
Quoted 26 lines · Charles Manning
Quoted 13 lines · On Friday 29 October 2010 06:26:41 Randy Dunlap wrote:
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.Quoted 7 lines
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.Hi Randy
Thanks for the response.
Quoted 7 lines
At this stage I'm hoping for some high level feedback about code layout etc. and don't expect an immediate approval. I expect to do some further code cleansing before getting a green light.
We're talking around 15k lines of code. Is a huge patch set the right way?
I thought it would be more polite to invite people to look at git, rather
than filling everyone's inboxes.
Have you read Documentation/SubmittingPatches and Documentation/development_process/ which explains how to break up your code and send it out for review properly?
No one is going to look at a random git tree with 15k lines of code for a review, sorry. Would you?
thanks,
greg k-h
Quoted 35 lines · Greg KH
Quoted 26 lines · Charles Manning
Quoted 13 lines · On Friday 29 October 2010 06:26:41 Randy Dunlap wrote:
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review& comment on a git tree.
We prefer patches via email for review.Quoted 7 lines
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.Hi Randy
Thanks for the response.
Quoted 7 lines
At this stage I'm hoping for some high level feedback about code layout etc. and don't expect an immediate approval. I expect to do some further code cleansing before getting a green light.
We're talking around 15k lines of code. Is a huge patch set the right way?
I thought it would be more polite to invite people to look at git, rather
than filling everyone's inboxes.
Quoted 7 lines
Have you read
Documentation/SubmittingPatchesandDocumentation/development_process/which explains how to break up your code and send it out for review properly?No one is going to look at a random git tree with 15k lines of code for a review, sorry. Would you?
The vast majority of the changes are just adding new files. All Those can be found in:
http://github.com/cdhmanning/linux-yaffs-integration/tree/yaffs-integration/fs/yaffs2/
That said, one could imagine a scenario where a single patch was created that added the contents of that directory. That patch could then be send to the relevant mailing lists as several people have pointed out.
Certainly replying to a patch submission e-mail is much closer to the standard kernel development process than trying to comment on files in some random git tree.
David Daney
Quoted 40 lines · David Daney
Quoted 39 lines · Greg KH
Quoted 26 lines · Charles Manning
Quoted 13 lines · On Friday 29 October 2010 06:26:41 Randy Dunlap wrote:
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review& comment on a git tree.
We prefer patches via email for review.Quoted 7 lines
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.Hi Randy
Thanks for the response.
Quoted 7 lines
At this stage I'm hoping for some high level feedback about code layout etc. and don't expect an immediate approval. I expect to do some further code cleansing before getting a green light.
We're talking around 15k lines of code. Is a huge patch set the right way?
I thought it would be more polite to invite people to look at git, rather
than filling everyone's inboxes.Have you read
Documentation/SubmittingPatchesandDocumentation/development_process/which explains how to break up your code and send it out for review properly?
Quoted 8 lines
Quoted 3 lines
No one is going to look at a random git tree with 15k lines of code for a review, sorry. Would you?
The vast majority of the changes are just adding new files. All Those can be found in:
http://github.com/cdhmanning/linux-yaffs-integration/tree/yaffs-integration/fs/yaffs2/
How can one easily write an email response to any code in a git tree?
Quoted 4 lines
That said, one could imagine a scenario where a single patch was created that added the contents of that directory. That patch could then be send to the relevant mailing lists as several people have pointed out.
Yes, that is what needs to be done, and is what happens for all other kernel code, why would this be an exception?
Quoted 3 lines
Certainly replying to a patch submission e-mail is much closer to the standard kernel development process than trying to comment on files in some random git tree.
Exactly.
Quoted 12 lines · Randy Dunlap
Quoted 6 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at http://github.com/cdhmanning/linux-yaffs-integration/
It's difficult to review & comment on a git tree.
We prefer patches via email for review.
Quoted 7 lines
Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.
I'd be glad to add the code to the staging tree, but to do so, do you have a list of things that are left to do in order to get it properly merged to the "real" portion of the kernel?
And if so, what is preventing you from doing those tasks right now to get the code into the .38 kernel merge?
thanks,
greg k-h
Quoted 19 lines · On Friday 29 October 2010 06:44:32 Greg KH wrote:
Quoted 18 lines · Randy Dunlap
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?
Quoted 6 lines
Quoted 2 lines
Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.I'd be glad to add the code to the staging tree, but to do so, do you have a list of things that are left to do in order to get it properly merged to the "real" portion of the kernel?
We're getting into a Catch-22 discussion here... Until I fully understand what is needed, I can't really say what needs to be done :-).
At this stage the code works, is integrated into, and compiles cleanly against Linus' 2.6 git. My git is based on Linus' 2.6 as of yesterday.
I have done symbol cleaning changing the old yaffs names of the form yaffs_ScanBackwards() to yaffs_scan_backward() etc.
What I really need is someone to look at what's there and tell me if there are still style issues etc that need changing.
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Quoted 3 lines
And if so, what is preventing you from doing those tasks right now to get the code into the .38 kernel merge?
My biggest problem is not fully understanding the process. Knowing if I need to change anything else and whom to send what to,
Thanks. Your input is much appreciated.
Charles
Quoted 33 lines · Charles Manning
Quoted 19 lines · On Friday 29 October 2010 06:44:32 Greg KH wrote:
Quoted 18 lines · Randy Dunlap
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Quoted 6 lines
Quoted 2 lines
Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.I'd be glad to add the code to the staging tree, but to do so, do you have a list of things that are left to do in order to get it properly merged to the "real" portion of the kernel?
We're getting into a Catch-22 discussion here... Until I fully understand what is needed, I can't really say what needs to be done :-).
At this stage the code works, is integrated into, and compiles cleanly against Linus' 2.6 git. My git is based on Linus' 2.6 as of yesterday.
Quoted 8 lines
I have done symbol cleaning changing the old yaffs names of the form
yaffs_ScanBackwards()toyaffs_scan_backward()etc.What I really need is someone to look at what's there and tell me if there are still style issues etc that need changing.
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Not really.
Have you run it through sparse and scripts/checkpatch.pl? If not, please do so and resolve all of the issues that they bring up.
Then break up the filesystem into reviewable patches and send them to the linux-fsdevel list for review.
Again, read Documentation/SubmittingPatches for the details on how to properly do this, it is described in very good detail :)
Quoted 4 lines
Quoted 2 lines
And if so, what is preventing you from doing those tasks right now to get the code into the .38 kernel merge?
My biggest problem is not fully understanding the process.
The process is very well documented, have you read the documentation? If so, what part is lacking?
thanks,
greg k-h
Quoted 8 lines · Greg KH
Quoted 2 lines · Charles Manning
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Not really.
Have you run it through sparse and
scripts/checkpatch.pl? If not, please do so and resolve all of the issues that they bring up.
I wouldn't do that. Checkpatch is useful but frequently wrong. By all means do use checkpatch, but please use your own taste to determine what you think needs fixing.
Quoted 5 lines · Joe Perches
Quoted 4 lines · Greg KH
Quoted 2 lines · Charles Manning
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Quoted 8 lines
Quoted 4 lines
Not really.
Have you run it through sparse and
scripts/checkpatch.pl? If not, please do so and resolve all of the issues that they bring up.I wouldn't do that. Checkpatch is useful but frequently wrong. By all means do use checkpatch, but please use your own taste to determine what you think needs fixing.
Absolutely.
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 54 lines · On Friday 29 October 2010 07:08:45 Greg KH wrote:
Quoted 33 lines · Charles Manning
Quoted 19 lines · On Friday 29 October 2010 06:44:32 Greg KH wrote:
Quoted 18 lines · Randy Dunlap
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Quoted 6 lines
Quoted 2 lines
Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.I'd be glad to add the code to the staging tree, but to do so, do you have a list of things that are left to do in order to get it properly merged to the "real" portion of the kernel?
We're getting into a Catch-22 discussion here... Until I fully understand what is needed, I can't really say what needs to be done :-).
At this stage the code works, is integrated into, and compiles cleanly against Linus' 2.6 git. My git is based on Linus' 2.6 as of yesterday.
Quoted 8 lines
I have done symbol cleaning changing the old yaffs names of the form
yaffs_ScanBackwards()toyaffs_scan_backward()etc.What I really need is someone to look at what's there and tell me if there are still style issues etc that need changing.
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Not really.
Have you run it through sparse and
scripts/checkpatch.pl? If not, please do so and resolve all of the issues that they bring up.Then break up the filesystem into reviewable patches and send them to the linux-fsdevel list for review.
Again, read
Documentation/SubmittingPatchesfor the details on how to properly do this, it is described in very good detail :)
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
And if so, what is preventing you from doing those tasks right now to get the code into the .38 kernel merge?
My biggest problem is not fully understanding the process.
The process is very well documented, have you read the documentation? If so, what part is lacking?
Thanks to all for the input. I'll be re-reading the docs and running the various scripts etc. That will probably keep me busy for a bit.
The one thing I'm still blurry on is whether it is OK to send a whole fs of 15kloc as a single patch to all. SubmitPatch seems to be written from the perspective of writing smaller patches.I guess checkpatch.pl will tell me :-).
-- Charles
Quoted 63 lines · Charles Manning
Quoted 54 lines · On Friday 29 October 2010 07:08:45 Greg KH wrote:
Quoted 33 lines · Charles Manning
Quoted 19 lines · On Friday 29 October 2010 06:44:32 Greg KH wrote:
Quoted 18 lines · Randy Dunlap
Quoted 8 lines · On Fri, 29 Oct 2010 04:55:02 +1300 Charles Manning wrote:
YAFFS has been used for many years as a third-party patch-in.
I have recently been through the exercise of changing all the symbols to be more kernel friendly with the intention of mainlining into the linux tree.
The code is in git at
http://github.com/cdhmanning/linux-yaffs-integration/It's difficult to review & comment on a git tree.
We prefer patches via email for review.Quoted 4 lines
Thanks to CELF and Google for sponsoring the effort so far.
What still needs to be done to mainline this?
Who do I need to approach?Quoted 6 lines
Quoted 2 lines
Either ask Stephen Rothwell to add the git tree to the linux-next daily tree or ask Greg KH to add it to the
drivers/staging/area.I'd be glad to add the code to the staging tree, but to do so, do you have a list of things that are left to do in order to get it properly merged to the "real" portion of the kernel?
We're getting into a Catch-22 discussion here... Until I fully understand what is needed, I can't really say what needs to be done :-).
At this stage the code works, is integrated into, and compiles cleanly against Linus' 2.6 git. My git is based on Linus' 2.6 as of yesterday.
Quoted 8 lines
I have done symbol cleaning changing the old yaffs names of the form
yaffs_ScanBackwards()toyaffs_scan_backward()etc.What I really need is someone to look at what's there and tell me if there are still style issues etc that need changing.
I know there is a style guide etc, but when we're talking about processing 15k loc then some of those rules might be slightly bendable.
Not really.
Have you run it through sparse and
scripts/checkpatch.pl? If not, please do so and resolve all of the issues that they bring up.Then break up the filesystem into reviewable patches and send them to the linux-fsdevel list for review.
Again, read
Documentation/SubmittingPatchesfor the details on how to properly do this, it is described in very good detail :)Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
And if so, what is preventing you from doing those tasks right now to get the code into the .38 kernel merge?
My biggest problem is not fully understanding the process.
The process is very well documented, have you read the documentation? If so, what part is lacking?
Quoted 7 lines
Thanks to all for the input. I'll be re-reading the docs and running the various scripts etc. That will probably keep me busy for a bit.
The one thing I'm still blurry on is whether it is OK to send a whole fs of 15kloc as a single patch to all. SubmitPatch seems to be written from the perspective of writing smaller patches.I guess checkpatch.pl will tell me :-).
lkml has a single email limit of 400 KB IIRC. netdev list is also large, but fsdevel may not be quite that large.
How big is the patch (in KB, not lines of code)?
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"RD" == Randy Dunlap <[email protected]> writes:
RD> How big is the patch (in KB, not lines of code)?
Being the curious sort:
:; git clone --reference /pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://github.com/cdhmanning/linux-yaffs-integration.git
Cloning into linux-yaffs-integration...
remote: Counting objects: 55, done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 51 (delta 1), reused 51 (delta 1)
Receiving objects: 100% (51/51), 128.48 KiB, done.
Resolving deltas: 100% (1/1), done.
:; cd linux-yaffs-integration
:; git show | wc
17094 64514 448590
(It looks like the repo has only the one commit not also in Linus' tree, rather than a series of commits to add yaffs.)
-JimC
Signature · 1 line
James Cloos <[email protected]> OpenPGP: 1024D/ED7DAEA6