Skip to contentSkip to conversation

leds-net5501: taints kernel, add license

PATCH In review Randy Dunlap 3 participants 3 messages Nov 4, 2010 – Nov 5, 2010 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds-net5501: taints kernel, add license

From: Randy Dunlap <[email protected]>

Add MODULE_LICENSE() that matches file comments so that kernel is not tainted.

leds_net5501: module license 'unspecified' taints kernel.

---
 drivers/leds/leds-net5501.c |    2 ++
 1 file changed, 2 insertions(+)

Alessandro, why does this module not have a module_exit() function? I.e., why can it not be unloaded?

drivers/leds/leds-net5501.c +2 -0
@@ -92,3 +92,5 @@ unmap:
 }
 
 arch_initcall(soekris_init);
+
+MODULE_LICENSE("GPL");
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Add MODULE_LICENSE() that matches file comments so that kernel is not tainted.

leds_net5501: module license 'unspecified' taints kernel.

Quoted 17 lines
---
 drivers/leds/leds-net5501.c |    2 ++
 1 file changed, 2 insertions(+)

Alessandro, why does this module not have a module_exit() function? I.e., why can it not be unloaded?

drivers/leds/leds-net5501.c +2 -0
@@ -92,3 +92,5 @@ unmap:
 }
 
 arch_initcall(soekris_init);
+
+MODULE_LICENSE("GPL");
#2 lore raw
In reply to Randy Dunlap
Quoted 3 lines · On Thu, 4 Nov 2010 10:28:00 -0700 Randy Dunlap <[email protected]> wrote:

Alessandro, why does this module not have a module_exit() function? I.e., why can it not be unloaded?

I believe there's no particular reason.
Bjarke Istrup Pedersen is taking care of this code (CCd).

Signature · 6 lines
 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it