APPARMOR: Fix memory leak of alloc_namespace()
Subsystems (2)
PATCH 1/1 APPARMOR: Fix memory leak of alloc_namespace()
policy->name is a substring of policy->hname, if prefix is not NULL, it will allocted strlen(prefix) + strlen(name) + 3 bytes to policy->hname in policy_init(). use kzfree(ns->base.name) will casue memory leak if alloc_namespace() failed.
Signed-off-by Zhitong Wang <[email protected]>
--- security/apparmor/policy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
security/apparmor/policy.c +1 -1
@@ -306,7 +306,7 @@ static struct aa_namespace *alloc_namespace(const char *prefix,return ns; fail_unconfined: -kzfree (ns->base.name); +kzfree (ns->base.hname); fail_ns:kzfree (ns);return NULL ;
Signature · 1 line
1.6.5.3
John Johansen
maintainerQuoted 5 lines · On 11/09/2010 07:31 PM, [email protected] wrote:
policy->nameis a substring ofpolicy->hname, if prefix is not NULL, it will allocted strlen(prefix) + strlen(name) + 3 bytes topolicy->hnameinpolicy_init(). usekzfree(ns->base.name)will casue memory leak ifalloc_namespace()failed.Signed-off-by Zhitong Wang <[email protected]>
yes, thank you.
Signed-off-by John Johansen <[email protected]>
Quoted 18 lines
--- security/apparmor/policy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)security/apparmor/policy.c +1
-1@@ -306,7 +306,7 @@ static struct aa_namespace *alloc_namespace(const char *prefix,return ns; fail_unconfined: -kzfree (ns->base.name); +kzfree (ns->base.hname); fail_ns:kzfree (ns);return NULL ;