Skip to contentSkip to conversation

RFC: missing patch review for LL TEMAC driver to u-boot

U-Boot Stephan Linz 2 participants 6 messages Nov 16, 2010 – Nov 25, 2010

lore
Share & tools
lore
#0 lore raw

Hi Ben,
Hi Michal,

in terms of your last communication:

http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html

... I want ask about the state of the review. When will the patch be added in the mainstream?

As far as I can see there were more than a try to submit the patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html

@Ben: What's wrong?

@Michal: Where can I find the latest commit for cherry-pick?

Signature · 9 lines
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L
#1 lore raw

Hi Stephan,

Quoted 9 lines · Stephan Linz

Hi Ben,
Hi Michal,

in terms of your last communication:

http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html

... I want ask about the state of the review. When will the patch be added in the mainstream?

From my point of view. I am not pushing Ben and Ben has to give up
Network custodianship.

Quoted 9 lines

As far as I can see there were more than a try to submit the patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html

@Ben: What's wrong?

@Michal: Where can I find the latest commit for cherry-pick?

You can look at this.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Michal

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#2 lore raw

Hi Michal,

Am Mittwoch, 17. November 2010, um 11:38:07 schrieb Michal Simek:

Quoted 12 lines

Hi Stephan,

Quoted 9 lines · Stephan Linz

Hi Ben,
Hi Michal,

in terms of your last communication:

http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html

... I want ask about the state of the review. When will the patch be added in the mainstream?

OK, things are coming and going -- that's live.

Quoted 9 lines

From my point of view. I am not pushing Ben and Ben has to give up
Network custodianship.

Quoted 5 lines

As far as I can see there were more than a try to submit the patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html

Quoted 6 lines
Quoted 3 lines

@Ben: What's wrong?

@Michal: Where can I find the latest commit for cherry-pick?

You can look at this.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Thank you very much for your fast reaction. I'll try out the new implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list. Give me time until Friday.

Signature · 9 lines
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L
#3 lore raw

Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:

Quoted 4 lines

Hi Michal,

--snip--

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

@Michal: Where can I find the latest commit for cherry-pick?

You can look at this.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Thank you very much for your fast reaction. I'll try out the new implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list. Give me time until Friday.

Hi Michal,

thanks again. I've to fixed some bugs. The corresponding patches I will send in a separeted e-mail. Watch the mailing list / your inbox.

Now most things are working (see dump below) but sometimes I get more or less LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think it is not a problem with the driver, or not?

U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at 0x88F00000. Looking for phy ... OK
Waiting for link ... OK
100BASE-T/FD
BOOTP broadcast 1
DHCP client bound to address 192.168.10.175
Using Xilinx_LL_TEMAC device
TFTP from server 192.168.10.10; our IP address is 192.168.10.175 Filename '/ml605/linuximage.ub'.
Load address: 0x20900000
Loading: #################################################################

         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         ##############

done
Bytes transferred = 7837764 (779844 hex)

Signature · 9 lines
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L
#4 lore raw
Quoted 11 lines · Stephan Linz

Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:

Quoted 9 lines

Hi Michal,

--snip--

Quoted 3 lines
Quoted 1 line

@Michal: Where can I find the latest commit for cherry-pick?

You can look at this.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Thank you very much for your fast reaction. I'll try out the new implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list. Give me time until Friday.

Quoted 8 lines

Hi Michal,

thanks again. I've to fixed some bugs. The corresponding patches I will send in a separeted e-mail. Watch the mailing list / your inbox.

Now most things are working (see dump below) but sometimes I get more or less LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think it is not a problem with the driver, or not?

IMHO it has connection with your lan traffic. U-boot expect specific packet len but got different one.

Haven't had time to look your changes but hopefully I'll look at it hopefully soon.

Michal

Quoted 26 lines

U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at 0x88F00000. Looking for phy ... OK
Waiting for link ... OK
100BASE-T/FD
BOOTP broadcast 1
DHCP client bound to address 192.168.10.175
Using Xilinx_LL_TEMAC device
TFTP from server 192.168.10.10; our IP address is 192.168.10.175 Filename '/ml605/linuximage.ub'.
Load address: 0x20900000
Loading: #################################################################

         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         ##############

done
Bytes transferred = 7837764 (779844 hex)

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#5 lore raw

Am Donnerstag, 25. November 2010, um 10:25:02 schrieb Michal Simek:

Quoted 11 lines
Quoted 10 lines · Stephan Linz

Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:

Quoted 3 lines

Hi Michal,

--snip--

Hi Michal,

thanks again. I've to fixed some bugs. The corresponding patches I will send in a separeted e-mail. Watch the mailing list / your inbox.

Quoted 6 lines
Quoted 3 lines

Now most things are working (see dump below) but sometimes I get more or less LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think it is not a problem with the driver, or not?

IMHO it has connection with your lan traffic. U-boot expect specific packet len but got different one.

I think so too without to explore the whole network traffic. I will repeat my tests in another network (as fast as possible). Thanks for your efforts.

Quoted 3 lines

Haven't had time to look your changes but hopefully I'll look at it hopefully soon.

It's ok.

Stephan

Quoted 26 lines

Michal

Quoted 23 lines

U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at 0x88F00000. Looking for phy ... OK
Waiting for link ... OK
100BASE-T/FD
BOOTP broadcast 1
DHCP client bound to address 192.168.10.175
Using Xilinx_LL_TEMAC device
TFTP from server 192.168.10.10; our IP address is 192.168.10.175 Filename '/ml605/linuximage.ub'.
Load address: 0x20900000
Loading:
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
##############
done
Bytes transferred = 7837764 (779844 hex)

Signature · 9 lines
Viele Gr??e,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L