mm: add devmem_is_allowed() for STRICT_DEVMEM checking
Quoted 8 lines · Linux Kernel
Gitweb: http://git.kernel.org/linus/ec6743bb06510c7b629603ce35713d6ae9273579 Commit: ec6743bb06510c7b629603ce35713d6ae9273579 Parent: ca768b663131ca644689fcadc9ca092dcc96a758 Author: Hendrik Brueckner <[email protected]> AuthorDate: Wed Nov 10 10:05:55 2010 +0100 Committer: Martin Schwidefsky <[email protected]> CommitDate: Wed Nov 10 10:05:54 2010 +0100
Quoted 8 lines
[S390] mm: add
devmem_is_allowed()forSTRICT_DEVMEMcheckingProvide the
devmem_is_allowed()routine to restrict access to kernel memory from userspace.
Set theCONFIG_STRICT_DEVMEMconfig option to switch on checking.Signed-off-by Hendrik Brueckner <[email protected]>Signed-off-by Martin Schwidefsky <[email protected]>
[snip add kconfig]
...
Review
Quoted 4 lines
(quoted diff) +4
-0+static inline int devmem_is_allowed(unsigned long pfn) +{ + return 0; +}
So you add the config option that promises security, but then you always allow the access. This seems pointless ? Why bother having the option at all?
Dave
Quoted 22 lines · On Wed, 17 Nov 2010 13:03:21 -0500 Dave Jones <[email protected]> wrote:
Quoted 8 lines · Linux Kernel
Gitweb: http://git.kernel.org/linus/ec6743bb06510c7b629603ce35713d6ae9273579 Commit: ec6743bb06510c7b629603ce35713d6ae9273579 Parent: ca768b663131ca644689fcadc9ca092dcc96a758 Author: Hendrik Brueckner <[email protected]> AuthorDate: Wed Nov 10 10:05:55 2010 +0100 Committer: Martin Schwidefsky <[email protected]> CommitDate: Wed Nov 10 10:05:54 2010 +0100Quoted 8 lines
[S390] mm: add
devmem_is_allowed()forSTRICT_DEVMEMcheckingProvide the
devmem_is_allowed()routine to restrict access to kernel memory from userspace.
Set theCONFIG_STRICT_DEVMEMconfig option to switch on checking.Signed-off-by Hendrik Brueckner <[email protected]>Signed-off-by Martin Schwidefsky <[email protected]>[snip add kconfig]
...
Quoted 7 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+static inline int devmem_is_allowed(unsigned long pfn) +{ + return 0; +}So you add the config option that promises security, but then you always allow the access. This seems pointless ? Why bother having the option at all?
It is the other way around, access is always disallowed. So it is very secure, access via /dev/mem is disabled if STRICT_DEVMEM=y.
Signature · 4 lines
blue skies, Martin. "Reality continues to ruin my life." - Calvin.