Skip to contentSkip to conversation

Rename RESET_VECTOR_ADDRESS ?

U-Boot Wolfgang Denk 2 participants 2 messages Nov 28, 2010 – Nov 29, 2010

lore
Share & tools
lore
#0 lore raw

Dear Andy & Kumar,

a number of boards define RESET_VECTOR_ADDRESS in their config.mk files:

board/freescale/corenet_ds/config.mk
board/freescale/mpc8536ds/config.mk
board/freescale/mpc8572ds/config.mk
board/freescale/p1022ds/config.mk
board/freescale/p1_p2_rdb/config.mk
board/freescale/p2020ds/config.mk

The only place where RESET_VECTOR_ADDRESS ever gets used is in the respective u-boot.lds linker script. Do you see any reason why we should not move these RESET_VECTOR_ADDRESS settings into the board config files? The linker script just needs to include "config.h", and we could remove all the config.mk files above.

What do you think?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never call a man a fool.  Borrow from him.
#1 lore raw
Quoted 18 lines · Wolfgang Denk

Dear Andy & Kumar,

a number of boards define RESET_VECTOR_ADDRESS in their config.mk files:

board/freescale/corenet_ds/config.mk
board/freescale/mpc8536ds/config.mk
board/freescale/mpc8572ds/config.mk
board/freescale/p1022ds/config.mk
board/freescale/p1_p2_rdb/config.mk
board/freescale/p2020ds/config.mk

The only place where RESET_VECTOR_ADDRESS ever gets used is in the respective u-boot.lds linker script. Do you see any reason why we should not move these RESET_VECTOR_ADDRESS settings into the board config files? The linker script just needs to include "config.h", and we could remove all the config.mk files above.

Quoted 5 lines

What do you think?

Best regards,

Wolfgang Denk

I don't see any issues with this, patch is welcome ;)

- k