Skip to contentSkip to conversation

Fix a couple of comments in scsi_request_fn

PATCH New Matthew Wilcox 1 participant 1 message Dec 16, 2010 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix a couple of comments in scsi_request_fn

The IO request lock was killed in 2.5, and we don't take the shost lock in scsi_dispatch_cmd any more.

drivers/scsi/scsi_lib.c +1 -5
index 5b6bbae..9e881cd 100644
@@ -1443,7 +1443,7 @@ static void scsi_softirq_done(struct request *rq)
  *
  * Returns:     Nothing
  *
- * Lock status: IO request lock assumed to be held when called.
+ * Lock status: request queue lock held, interrupts disabled
  */
 static void scsi_request_fn(struct request_queue *q)
 {
@@ -1530,10 +1530,6 @@ static void scsi_request_fn(struct request_queue *q)
 		scsi_target(sdev)->target_busy++;
 		shost->host_busy++;
 
-		/*
-		 * XXX(hch): This is rather suboptimal, scsi_dispatch_cmd will
-		 *		take the lock again.
-		 */
 		spin_unlock_irq(shost->host_lock);
 
 		/*
Signature · 4 lines
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."