smatch stuff: potential read past the end of the buffer
Hello Vasanthakumar,
Smatch complains that in linux-next 60e0c3a7 "ath9k_hw: Eeeprom changes for AR9485" means there is a potential read past the end of the buffer int ar9300_eeprom_restore_internal().
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +3381
ar9300_eeprom_restore_internal(81) error: buffer overflow 'word' 2048 <= 4099
"word" is allocated with 2048 bytes:
word = kzalloc(2048, GFP_KERNEL);
"length" can be up to 4099:
if ((!AR_SREV_9485(ah) && length >= 1024) ||
(AR_SREV_9485(ah) && length >= (4 * 1024))) {
^^^^^^^^^^^^^^^^^^^^^so "osize" can be up to 4099 as well:
osize = length;
We're reading way past the end of the word array here:
mchecksum = word[COMP_HDR_LEN + osize] |
^^^^^^^^^^^^^^^^^^^^^^^^^^
(word[COMP_HDR_LEN + osize + 1] << 8);I don't know how to fix this. Can you take a look?
regards,
dan carpenter
Quoted 19 lines · Dan Carpenter
Hello Vasanthakumar,
Smatch complains that in linux-next
60e0c3a7"ath9k_hw: Eeeprom changes for AR9485" means there is a potential read past the end of the buffer intar9300_eeprom_restore_internal().
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c+3381ar9300_eeprom_restore_internal(81) error: buffer overflow 'word' 2048 <= 4099"word" is allocated with 2048 bytes:
word = kzalloc(2048, GFP_KERNEL);"length" can be up to 4099:
if ((!AR_SREV_9485(ah) && length >= 1024) || (AR_SREV_9485(ah) && length >= (4 * 1024))) { ^^^^^^^^^^^^^^^^^^^^^so "osize" can be up to 4099 as well:
Quoted 8 lines
osize = length;We're reading way past the end of the word array here:
mchecksum = word[COMP_HDR_LEN + osize] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ (word[COMP_HDR_LEN + osize + 1] << 8);I don't know how to fix this. Can you take a look?
thanks for pointing this out. we shall look into this.
Quoted 8 lines
regards,
dan carpenter--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan,
Why not use min() function?
index = min(COMP_HDR_LEN + osize, 2046);
mchecksum = word[index] |
(word[index + 1] << 8);Or would smatch miss this in its analysis?
Gr. AvS
________________________________________
From: [email protected] [linux-wireless-owner at vger.kernel.org] On Behalf Of Dan Carpenter [error27 at gmail.com]
Sent: Monday, December 20, 2010 9:30 AM
To: Vasanthakumar Thiagarajan
Cc: linux-wireless at vger.kernel.org; [email protected]
Subject: smatch stuff: potential read past the end of the buffer
Hello Vasanthakumar,
Smatch complains that in linux-next 60e0c3a7 "ath9k_hw: Eeeprom changes for AR9485" means there is a potential read past the end of the buffer int ar9300_eeprom_restore_internal().
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +3381
ar9300_eeprom_restore_internal(81)
error: buffer overflow 'word' 2048 <= 4099"word" is allocated with 2048 bytes:
word = kzalloc(2048, GFP_KERNEL);
"length" can be up to 4099:
if ((!AR_SREV_9485(ah) && length >= 1024) ||
(AR_SREV_9485(ah) && length >= (4 * 1024))) {
^^^^^^^^^^^^^^^^^^^^^so "osize" can be up to 4099 as well:
osize = length;
We're reading way past the end of the word array here:
mchecksum = word[COMP_HDR_LEN + osize] |
^^^^^^^^^^^^^^^^^^^^^^^^^^
(word[COMP_HDR_LEN + osize + 1] << 8);I don't know how to fix this. Can you take a look?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info@ http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Arend Van Spriel
Hi Dan,
Why not use
min()function?index = min(COMP_HDR_LEN + osize, 2046); mchecksum = word[index] | (word[index + 1] << 8);Or would smatch miss this in its analysis?
That would silence the warning, but is it the right fix? I thought maybe we should make word a larger buffer?
regards,
dan carpenter
Hi Dan,
Agreed. But maybe there is no usage scenario in which the boundary is actually crossed. Have to wait for ath9k developers to answer that.
Gr. AvS
________________________________________
From: Dan Carpenter [error27 at gmail.com]
Sent: Monday, December 20, 2010 1:42 PM
To: Arend Van Spriel
Cc: Vasanthakumar Thiagarajan; linux-wireless at vger.kernel.org; ath9k-devel at lists.ath9k.org
Subject: Re: smatch stuff: potential read past the end of the buffer
Quoted 8 lines · Arend Van Spriel
Hi Dan,
Why not use
min()function?index = min(COMP_HDR_LEN + osize, 2046); mchecksum = word[index] | (word[index + 1] << 8);Or would smatch miss this in its analysis?
That would silence the warning, but is it the right fix? I thought maybe we should make word a larger buffer?
regards,
dan carpenter
Quoted 10 lines · Dan Carpenter
Hello Vasanthakumar,
Smatch complains that in linux-next
60e0c3a7"ath9k_hw: Eeeprom changes for AR9485" means there is a potential read past the end of the buffer intar9300_eeprom_restore_internal().
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c+3381ar9300_eeprom_restore_internal(81) error: buffer overflow 'word' 2048 <= 4099
Quoted 6 lines
"word" is allocated with 2048 bytes:
word = kzalloc(2048, GFP_KERNEL);"length" can be up to 4099:
if ((!AR_SREV_9485(ah) && length >= 1024) || (AR_SREV_9485(ah) && length >= (4 * 1024))) {
Yeah, this looks buggy, the eeprom data length for AR9485 is 1088 bytes only, I'll send out a patch, thanks for reporting this.
Vasanth