typhoon: memory corruption in typhoon_get_drvinfo()
Subsystems (3)
PATCH 1/1 typhoon: memory corruption in typhoon_get_drvinfo()
info->version only has space for 32 characters but my UTS_RELEASE is "2.6.37-rc6-next-20101217-05817-ge935fc8-dirty" so it doesn't fit. This is supposed to be the version of the driver, not the kernel version. This driver doesn't have a version so lets just leave it blank.
Signed-off-by Dan Carpenter <[email protected]>
---
Found with static analysis. Compile tested.
drivers/net/typhoon.c +0 -1
@@ -1004,7 +1004,6 @@ typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) }strcpy (info->driver,KBUILD_MODNAME ); -strcpy (info->version,UTS_RELEASE );strcpy (info->bus_info,pci_name (pci_dev)); }
From: Dan Carpenter <[email protected]>
Date: Mon, 20 Dec 2010 16:00:18 +0300
Quoted 7 lines
info->versiononly has space for 32 characters but myUTS_RELEASEis "2.6.37-rc6-next-20101217-05817-ge935fc8-dirty" so it doesn't fit. This is supposed to be the version of the driver, not the kernel version. This driver doesn't have a version so lets just leave it blank.Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks.