Skip to contentSkip to conversation

USB: DL100B webmail notifier: initialize return value

PATCH New Melchior FRANZ 1 participant 1 message Dec 22, 2010 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: DL100B webmail notifier: initialize return value

From: Melchior FRANZ <[email protected]>

If case of an unknown usb_device_id->driver_info (which could only occur if the info got corrupted somewhere outside the usbled driver), a debug message depended on an uninitialized value. This was harmless, but ugly, and gets fixed with this patch.

---

@Greg:
Argh ... sorry about that. The build system didn't warn me, not even with EXTRA_CFLAGS=-W. And cppcheck ignored the problem as well. This must be a plot to damage my reputation! :-}

m.

 drivers/usb/misc/usbled.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/misc/usbled.c +1 -1
index 1732d9b..1616ad1 100644
@@ -45,7 +45,7 @@ struct usb_led {
 
 static void change_color(struct usb_led *led)
 {
-	int retval;
+	int retval = 0;
 	unsigned char *buffer;
 
 	buffer = kmalloc(8, GFP_KERNEL);