USB: cdc_ether: remove unneeded check

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 25, 2010 – Dec 31, 2010

Subsystems (5)

Networking Network drivers Kernel janitors USB networking drivers +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2010-12-25 22:23 UTC #0 lore raw

PATCH 1/1 USB: cdc_ether: remove unneeded check

We already verified that "dev->udev->actconfig->extralen" was non-zero so "len" is non-zero here as well.

Signed-off-by Dan Carpenter <[email protected]>

---
Compile tested.

drivers/net/usb/cdc_ether.c +1 -3

index b3fe0de..9a60e41 100644
@@ -99,9 +99,7 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
 		 */
 		buf = dev->udev->actconfig->extra;
 		len = dev->udev->actconfig->extralen;
-		if (len)
-			dev_dbg(&intf->dev,
-				"CDC descriptors on config\n");
+		dev_dbg(&intf->dev, "CDC descriptors on config\n");
 	}
 
 	/* Maybe CDC descriptors are after the endpoint?  This bug has

Oliver Neukum

maintainer Acked-by on v1 1/1

2010-12-26 12:04 UTC #1 lore raw

Am Samstag, 25. Dezember 2010, 23:23:42 schrieb Dan Carpenter:

Quoted 4 lines

We already verified that "dev->udev->actconfig->extralen" was non-zero so "len" is non-zero here as well.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Oliver Neukum <[email protected]>

David Miller

maintainer Applied

2010-12-31 19:11 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Sun, 26 Dec 2010 01:23:42 +0300

Quoted 4 lines

We already verified that "dev->udev->actconfig->extralen" was non-zero so "len" is non-zero here as well.
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.