mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K

PATCH In review Kashyap, Desai 1 participant 1 message Jan 4, 2011 SCSI

Share & tools

Kashyap, Desai

author

2011-01-04 06:49 UTC #0 lore raw

PATCH 2/10 mpt2sas: Internal device reset complete event is not supported for older firmware prior to MPI Rev K

The "internal device reset complete" event is not supported
for older firmware prior to MPI Rev K We added
a check in the driver so the "internal device reset" event is ignored for older firmware. When ignored, the tm_busy flag doesn't get set nor cleared. Without this fix, IO queues would be froozen indefinetly after the "internal device reset" event, as the "complete" event never sent to clear the flag.

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/scsi/mpt2sas/mpt2sas_base.h +0 -0

drivers/scsi/mpt2sas/mpt2sas_scsih.c +6 -0

index 95d8274..a16f2a0 100644
@@ -5002,6 +5002,12 @@ _scsih_sas_device_status_change_event(struct MPT2SAS_ADAPTER *ioc,
 		     event_data);
 #endif
 
+	/* In MPI Revision K (0xC), the internal device reset complete was
+	 * implemented, so avoid setting tm_busy flag for older firmware.
+	 */
+	if ((ioc->facts.HeaderVersion >> 8) < 0xC)
+		return;
+
 	if (event_data->ReasonCode !=
 	    MPI2_EVENT_SAS_DEV_STAT_RC_INTERNAL_DEVICE_RESET &&
 	   event_data->ReasonCode !=