Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

PATCH Applied Nikanth Karthikesan 2 participants 2 messages Mar 17, 2011 – Apr 10, 2011 3 messages not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Nikanth Karthikesan

author

2011-03-17 05:37 UTC #3 lore raw

PATCH 1/1 Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

From: Nikanth Karthikesan <[email protected]>
Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

When the kernel does partition detection, on certain configurations with external fibre channel raid systems (e.g. clariion from EMC) the read would fail. And "ldm_validate_partition_table(): Disk read failed" messages are printed to the console.

But the failure to read is not a critical error. Now since the message is flagged as KERN_CRIT, it gets printed even when booting with the "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to read here is not really an error.

Signed-off-by Nikanth Karthikesan <[email protected]>

Reported-by Klaus Hartmann <[email protected]>

Signed-off-by Anton Altaparmakov <[email protected]>

---

fs/partitions/ldm.c +1 -1

index b10e354..ea648b9 100644
@@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}

Jiri Kosina

Applied

2011-04-10 15:05 UTC #4 lore raw

Quoted 24 lines · Nikanth Karthikesan

From: Nikanth Karthikesan <[email protected]>
Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"
When the kernel does partition detection, on certain configurations with external fibre channel raid systems (e.g. clariion from EMC) the read would fail. And "ldm_validate_partition_table(): Disk read failed" messages are printed to the console.
But the failure to read is not a critical error. Now since the message is flagged as KERN_CRIT, it gets printed even when booting with the "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to read here is not really an error.
Signed-off-by Nikanth Karthikesan <[email protected]>
Reported-by Klaus Hartmann <[email protected]>
Signed-off-by Anton Altaparmakov <[email protected]>
---
fs/partitions/ldm.c +0 -0
index b10e354..ea648b9 100644

fs/partitions/ldm.c static bool ldm_validate_partition_table(struct parsed_partitions *state) · line 570

Quoted 7 lines

fs/partitions/ldm.c +1 -1

@@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}

Applied, thanks.

Signature · 2 lines

Jiri Kosina
SUSE Labs, Novell Inc.