sysclt_check: drop table->procname checks

PATCH New Denis Kirjanov 1 participant 1 message Feb 5, 2011 Proc sysctl

lore

Share & tools

lore

Denis Kirjanov

author

2011-02-05 10:39 UTC #0 lore raw

PATCH 1/2 sysclt_check: drop table->procname checks

Sine the for loop checks for the table->procname drop useless table->procname checks inside the loop body

Signed-off-by Denis Kirjanov <[email protected]>

---
 kernel/sysctl_check.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

kernel/sysctl_check.c +2 -4

index 10b90d8..3a01c3e 100644
@@ -111,11 +111,9 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
 		const char *fail = NULL;
 
 		if (table->parent) {
-			if (table->procname && !table->parent->procname)
+			if (!table->parent->procname)
 				set_fail(&fail, table, "Parent without procname");
 		}
-		if (!table->procname)
-			set_fail(&fail, table, "No procname");
 		if (table->child) {
 			if (table->data)
 				set_fail(&fail, table, "Directory with data?");

@@ -144,7 +142,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
 					set_fail(&fail, table, "No maxlen");
 			}
 #ifdef CONFIG_PROC_SYSCTL
-			if (table->procname && !table->proc_handler)
+			if (!table->proc_handler)
 				set_fail(&fail, table, "No proc_handler");
 #endif
 #if 0

Signature · 1 line

1.7.3.4