printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig

PATCH New Mandeep Singh Baines 1 participant 1 message Feb 9, 2011 1 message not in the archive Library code

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mandeep Singh Baines

author

2011-02-09 00:53 UTC #1 lore raw

PATCH v2 1/1 printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig

Quoted 9 lines · Andrew Morton

Quoted 6 lines · On Tue, 08 Feb 2011 13:52:51 -0800 Joe Perches <[email protected]> wrote:
Quoted 4 lines · On Tue, 2011-02-08 at 13:49 -0800, [email protected] wrote:
The patch titled
printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
has been removed from the -mm tree.
This patch was dropped because it had testing failures

Quoted 5 lines

Quoted 3 lines
The patch seems pretty simple.
What kind of testing failures did it have?
CONFIG_DEFAULT_MESSAGE_LOGLEVEL undefined with CONFIG_PRINTK=n (Randy)

D'oh. Fixed.

---

We've been burned by regressions/bugs which we later realized could have been triaged quicker if only we'd paid closer attention to dmesg. To make it easier to audit dmesg, we'd like to make DEFAULT_MESSAGE_LEVEL Kconfig-settable. That way we can set it to KERN_NOTICE and audit any messages <= KERN_WARNING.

Signed-off-by Mandeep Singh Baines <[email protected]>

---
 kernel/printk.c   |    2 +-
 lib/Kconfig.debug |   11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletions(-)

kernel/printk.c +1 -1

index 2ddbdc7..bddeee8 100644
@@ -53,7 +53,7 @@ void asmlinkage __attribute__((weak)) early_printk(const char *fmt, ...)
 #define __LOG_BUF_LEN	(1 << CONFIG_LOG_BUF_SHIFT)
 
 /* printk's without a loglevel use this.. */
-#define DEFAULT_MESSAGE_LOGLEVEL 4 /* KERN_WARNING */
+#define DEFAULT_MESSAGE_LOGLEVEL CONFIG_DEFAULT_MESSAGE_LOGLEVEL
 
 /* We show everything that is MORE important than this.. */
 #define MINIMUM_CONSOLE_LOGLEVEL 1 /* Minimum loglevel we let people use */

lib/Kconfig.debug +11 -0

index 3967c23..bd1760c 100644
@@ -9,6 +9,17 @@ config PRINTK_TIME
 	  operations.  This is useful for identifying long delays
 	  in kernel startup.
 
+config DEFAULT_MESSAGE_LOGLEVEL
+	int "Default message log level (1-7)"
+	range 1 7
+	default "4"
+	help
+	  Default log level for printk statements with no specified priority.
+
+	  This was hard-coded to KERN_WARNING since at least 2.6.10 but folks
+	  that are auditing their logs closely may want to set it to a lower
+	  priority.
+
 config ENABLE_WARN_DEPRECATED
 	bool "Enable __deprecated logic"
 	default y

Signature · 1 line

1.7.3.1