move double quotation marks so that keep MAINTAINERS consistent
PATCH 1/1 move double quotation marks so that keep MAINTAINERS consistent
Hi us,
When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.
Thanks.
Best Regards.
Harry Wei.
--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
@@ -139,7 +139,7 @@ S: Supported F: drivers/scsi/3w-* 53C700 AND 53C700-66 SCSI DRIVER -M: "James E.J. Bottomley" <[email protected]> +M: James E.J. Bottomley <[email protected]> L: [email protected] S: Maintained F: drivers/scsi/53c700*
Signature · 1 line
1.7.0.4
Quoted 3 lines · Harry Wei
Hi us,
When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.
The quotes are there to handle the '.' character which email clients need. If you have a question about a specific person's entry, why not email them about it? To not do so is a bit rude.
thanks,
greg k-h
Quoted 19 lines · On Thu, 10 Feb 2011 10:51:35 +0800 Harry Wei <[email protected]> wrote:
Hi us,
When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.Thanks.
Best Regards.
Harry Wei.Signed-off-by Harry Wei <[email protected]>--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)MAINTAINERS +0
-0
MAINTAINERS S: Supported · line 145
Quoted 8 lines
MAINTAINERS +1
-1@@ -139,7 +139,7 @@ S: Supported F: drivers/scsi/3w-* 53C700 AND 53C700-66 SCSI DRIVER -M: "James E.J. Bottomley" <[email protected]> +M: James E.J. Bottomley <[email protected]> L: [email protected] S: Maintained F: drivers/scsi/53c700*
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
Quoted 9 lines · harryxiyou
---------- Forwarded message ----------
From: Greg KH <[email protected]>
Date: 2011/2/10
Subject: Re: [PATCH]move double quotation marks so that keepMAINTAINERSconsistent
To: [email protected], [email protected], [email protected], [email protected], [email protected]
Quoted 8 lines
Quoted 3 lines · Harry Wei
Hi us,
When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.The quotes are there to handle the '.' character which email clients need. If you have a question about a specific person's entry, why not email them about it? To not do so is a bit rude.
Hi greg, Andrew
So sorry. I ignored it :( I will send a mail to James E. J. Bottomley for this matter. Then i will decide if we should delete this double-quotation-marks. Thanks. Best Regards. Harry Wei.
Quoted 16 lines
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/Signature · 3 lines
Best Regards. Harry Wei. Do what u like!
From: Andrew Morton <[email protected]>
Date: Wed, 9 Feb 2011 19:06:31 -0800
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.
Quoted 7 lines · David Miller
From: Andrew Morton <[email protected]>
Date: Wed, 9 Feb 2011 19:06:31 -0800Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
Quoted 6 lines
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.
Ok, but should not MUA do this quotation? Quick test shows that mutt does...
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt does...
My recollection is that the get_maintainer script
cannot parse M: lines with multiple entries with
periods without the quotes.
M: First I. Last <[email protected]>, Last.I.First <[email protected]>
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.
Quoted 30 lines · harryxiyou
---------- Forwarded message ----------
From: Joe Perches <[email protected]>
Date: 2011/2/20
Subject: Re: [PATCH]move double quotation marks so that keepMAINTAINERSconsistent
To: Pavel Machek <[email protected]>
Cc: David Miller <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected]Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt
does...
My recollection is that the
get_maintainerscript
cannot parse M: lines with multiple entries with
periods without the quotes.M: First I. Last <[email protected]>, Last.I.First <[email protected]>
Quoted 7 lines
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.
Hi Joe,
In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the MAINTAINERS ? Maybe we have other better ways? Tell me and i will patch for us. Like the Greg K-H said, we should firstly notify the maintainers who have the double-quotation-marks in their M:. Then we can make this patch :)
Thanks.
Best Regards.
Harry Wei.
Quoted 13 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/Signature · 3 lines
Best Regards. Harry Wei. Do what u like!
PATCH 1/1 MAINTAINERS: Quote non-alphanumeric email addresses
Add quotes around email address with periods and commas.
---
Quoted 22 lines · Harry Wei
Quoted 12 lines · harryxiyou
From: Joe Perches <[email protected]>
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt
Quoted 9 lines
does...
My recollection is that theget_maintainerscript cannot parse M: lines with multiple entries with periods without the quotes.
M: First I. Last <[email protected]>, Last.I.First <[email protected]>
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.
Quoted 2 lines
In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the
MAINTAINERS?
No, that'd be wrong before improving parsing and verifying that all currently used client/MUAs work without quotes.
Quoted 1 line
Maybe we have other better ways? Tell me and i will patch for us.
I think leaving the quotes is the right thing to do.
Quoting names that have non alphanumeric characters before any open angle bracket '<' is better than remove quotes.
MAINTAINERS | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
MAINTAINERS +5 -5
@@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers) S: Maintained ARM/TETON BGA MACHINE SUPPORT -M: Mark F. Brown <[email protected]> +M: "Mark F. Brown" <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained
@@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c BLUETOOTH DRIVERS M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -1457,7 +1457,7 @@ F: drivers/bluetooth/ BLUETOOTH SUBSYSTEM M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt F: drivers/block/cpqarray.* HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa) -M: Stephen M. Cameron <[email protected]> +M: "Stephen M. Cameron" <[email protected]> L: [email protected] S: Supported F: Documentation/scsi/hpsa.txt
@@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio F: drivers/char/mxser.* MSI LAPTOP SUPPORT -M: Lee, Chun-Yi <[email protected]> +M: "Lee, Chun-Yi" <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/msi-laptop.c
Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
Quoted 3 lines · Joe Perches
Add quotes around email address with periods and commas.
Signed-off-by Joe Perches <[email protected]>
But i think you should also tell the maintainers you add quotes for their M: in the MAINTAINERS.
Quoted 93 lines
---
Quoted 22 lines · Harry Wei
Quoted 12 lines · harryxiyou
From: Joe Perches <[email protected]>
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt
Quoted 9 lines
does...
My recollection is that theget_maintainerscript cannot parse M: lines with multiple entries with periods without the quotes.
M: First I. Last <[email protected]>, Last.I.First <[email protected]>
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.Quoted 2 lines
In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the
MAINTAINERS?No, that'd be wrong before improving parsing and verifying that all currently used client/MUAs work without quotes.
Quoted 1 line
Maybe we have other better ways? Tell me and i will patch for us.
I think leaving the quotes is the right thing to do.
Quoting names that have non alphanumeric characters before any open angle bracket '<' is better than remove quotes.
MAINTAINERS | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)MAINTAINERS +5
-5@@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers) S: Maintained ARM/TETON BGA MACHINE SUPPORT -M: Mark F. Brown <[email protected]> +M: "Mark F. Brown" <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained@@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c BLUETOOTH DRIVERS M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git@@ -1457,7 +1457,7 @@ F: drivers/bluetooth/ BLUETOOTH SUBSYSTEM M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git@@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt F: drivers/block/cpqarray.* HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa) -M: Stephen M. Cameron <[email protected]> +M: "Stephen M. Cameron" <[email protected]> L: [email protected] S: Supported F: Documentation/scsi/hpsa.txt@@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio F: drivers/char/mxser.* MSI LAPTOP SUPPORT -M: Lee, Chun-Yi <[email protected]> +M: "Lee, Chun-Yi" <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/msi-laptop.c
Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
In reply to Joe PerchesQuoted 34 lines · Joe Perches
Add quotes around email address with periods and commas.
Signed-off-by Joe Perches <[email protected]>---
Quoted 22 lines · Harry Wei
Quoted 12 lines · harryxiyou
From: Joe Perches <[email protected]>
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt
Quoted 9 lines
does...
My recollection is that theget_maintainerscript cannot parse M: lines with multiple entries with periods without the quotes.
M: First I. Last <[email protected]>, Last.I.First <[email protected]>
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.Quoted 2 lines
In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the
MAINTAINERS?No, that'd be wrong before improving parsing and verifying that all currently used client/MUAs work without quotes.
Quoted 7 lines
Quoted 1 line
Maybe we have other better ways? Tell me and i will patch for us.
I think leaving the quotes is the right thing to do.
Quoting names that have non alphanumeric characters before any open angle bracket '<' is better than remove quotes.
Hmm, what about some other conditions except
for periods and commas in maintainers' M:.
Like following:
1> Character '-' in M:
CALGARY x86-64 IOMMU
Muli Ben-Yehuda <[email protected]>
2> No name of the M:
M: [email protected]
3> Messy code in M:
M: Benoît Cousson <[email protected]>
Should we also patch for them?
Can client/MUAs work them well?
Thanks.
Best Regards.
Harry Wei.
Quoted 55 lines
MAINTAINERS | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)MAINTAINERS +5
-5@@ -1044,7 +1044,7 @@ L: [email protected] (moderated for non-subscribers) S: Maintained ARM/TETON BGA MACHINE SUPPORT -M: Mark F. Brown <[email protected]> +M: "Mark F. Brown" <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained@@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c BLUETOOTH DRIVERS M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git@@ -1457,7 +1457,7 @@ F: drivers/bluetooth/ BLUETOOTH SUBSYSTEM M: Marcel Holtmann <[email protected]> -M: Gustavo F. Padovan <[email protected]> +M: "Gustavo F. Padovan" <[email protected]> L: [email protected] W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git@@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt F: drivers/block/cpqarray.* HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa) -M: Stephen M. Cameron <[email protected]> +M: "Stephen M. Cameron" <[email protected]> L: [email protected] S: Supported F: Documentation/scsi/hpsa.txt@@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio F: drivers/char/mxser.* MSI LAPTOP SUPPORT -M: Lee, Chun-Yi <[email protected]> +M: "Lee, Chun-Yi" <[email protected]> L: [email protected] S: Maintained F: drivers/platform/x86/msi-laptop.c
Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
Quoted 6 lines · Harry Wei
Quoted 1 line · Joe Perches
Add quotes around email address with periods and commas.
Hmm, what about some other conditions except
for periods and commas in maintainers' M:.
Like following:
1> Character '-' in M:
Dashes are not an issue.
Quoted 2 lines
2> No name of the M:
M: [email protected]
Names and angle brackets are optional.
Quoted 2 lines
3> Messy code in M:
M: Benoît Cousson <[email protected]>
8 bit characters _might_ be an issue, but no one has reported any problems yet.
I think you should read and understand rfc 2822 before continuing with this.
Utilities like git send-email and get_maintainer.pl generally provide email address parsing for only a subset of all valid address styles.
As these utilities are done mostly by regex, not all valid email addresses are supported because the regex validations get ridiculously complicated.
There are some "monster" regex classes that attempt to support a greater range of valid email address styles, but the pain of implementation generally isn't worth it.
You're free to try to improve it of course, but I think that modifications to the address styles currently used in MAINTAINERS to remove "special" address style handling isn't necessary.
Re: Fwd: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
In reply to a message not in the archiveQuoted 11 lines · jiaweiwei
---------- Forwarded message ----------
From: Joe Perches <[email protected]>
Date: 2011/2/21
Subject: Re: [PATCH]MAINTAINERS: Quote non-alphanumeric email addresses
To: Harry Wei <[email protected]>
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
Quoted 8 lines
Quoted 6 lines · Joe Perches
Quoted 1 line
Add quotes around email address with periods and commas.
Hmm, what about some other conditions except
for periods and commas in maintainers' M:.
Like following:
1> Character '-' in M:Dashes are not an issue.
Get it.
Quoted 5 lines
Quoted 3 lines
2> No name of the M:
M: [email protected]Names and angle brackets are optional.
Ok.
Quoted 6 lines
Quoted 3 lines
3> Messy code in M:
M: Benoît Cousson <[email protected]>8 bit characters _might_ be an issue, but no one has reported any problems yet.
Get it.
Quoted 3 lines
I think you should read and understand rfc 2822 before continuing with this.
Thanks, i will read it :)
Quoted 14 lines
Utilities like git send-email and get_maintainer.pl generally provide email address parsing for only a subset of all valid address styles.
As these utilities are done mostly by regex, not all valid email addresses are supported because the regex validations get ridiculously complicated.
There are some "monster" regex classes that attempt to support a greater range of valid email address styles, but the pain of implementation generally isn't worth it.
Quoted 4 lines
You're free to try to improve it of course, but I think that modifications to the address styles currently used in
MAINTAINERSto remove "special" address style handling isn't necessary.
Get it, thanks.
Best Regards.
Harry Wei.
Quoted 6 lines
Signature · 2 lines
-- do kernel
Quoted 18 lines · On Sat, 19 Feb 2011 13:59:50 -0800 Joe Perches <[email protected]> wrote:
Quoted 10 lines · Pavel Machek
Quoted 8 lines · David Miller
From: Andrew Morton <[email protected]>
Quoted 3 lines
I suspect that some mail clients will explode if you provide them with an unquoted string containing periods. That would make copy-n-paste rather a hassle.
It's not clients, it's servers.
SMTP rules state that characters such as "." cannot appear unquoted in email headers.
vger.kernel.org rejects mail when this violation occurs.Ok, but should not MUA do this quotation? Quick test shows that mutt does...
My recollection is that the
get_maintainerscript
cannot parse M: lines with multiple entries with
periods without the quotes.M: First I. Last <[email protected]>, Last.I.First <[email protected]>
Quoted 8 lines
fails and
M: "First I. Last" <[email protected]>, "Last.I.First" <[email protected]>
succeeds.
You are welcome to improve the parsing in that routine.
There are perl modules providing full rfc parsing of email addresses (with all those weird cases nobody uses) ... but i doubt it's urgent, especially as we can more or less control the input to get_maintainer.pl by controlling the MAINTAINER file and the git version history ...