Skip to contentSkip to conversation

LOOKUP_CREATE checks in nfs ->create() instances

DISCUSSION Al Viro 2 participants 3 messages Feb 17, 2011 VFS

lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw
	When are they _not_ true?  AFAICS, calls of ->create() with

non-NULL nameidata are very limited to start with:
* ecryptfs one - called from its own ->create(), without changes
in LOOKUP_CREATE presence.
* sys_mknodat() - called after we'd done lookup_create(), which
sets LOOKUP_CREATE (and LOOKUP_EXCL), with O_EXCL in intent flags. Nothing ever removes LOOKUP_CREATE once it's set.
* __open_namei_create(), which is called from from do_filp_open()
and only if we had O_CREAT passed in flags. In that case LOOKUP_CREATE will be set before we get there.

What am I missing here? AFAICS, there's no way to get nfs ->create() methods called without LOOKUP_CREATE present in nd->flags...

#1 lore raw
Quoted 11 lines · Al Viro
	When are they _not_ true?  AFAICS, calls of ->create() with

non-NULL nameidata are very limited to start with:
* ecryptfs one - called from its own ->create(), without changes
in LOOKUP_CREATE presence.
* sys_mknodat() - called after we'd done lookup_create(), which
sets LOOKUP_CREATE (and LOOKUP_EXCL), with O_EXCL in intent flags. Nothing ever removes LOOKUP_CREATE once it's set.
* __open_namei_create(), which is called from from do_filp_open()
and only if we had O_CREAT passed in flags. In that case LOOKUP_CREATE will be set before we get there.

Quoted 2 lines

What am I missing here? AFAICS, there's no way to get nfs ->create() methods called without LOOKUP_CREATE present in nd->flags...

Hi Al,

That is probably a remnant of the times before lookup_create() was changed to set the LOOKUP_CREATE intent in 2.6.18.

I'm fine with getting rid of those checks if they are no longer needed.

Cheers
Trond

Signature · 6 lines
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
www.netapp.com
author maintainer
#2 lore raw
Quoted 6 lines · Trond Myklebust

Hi Al,

That is probably a remnant of the times before lookup_create() was changed to set the LOOKUP_CREATE intent in 2.6.18.

I'm fine with getting rid of those checks if they are no longer needed.

Um... You mean, before we had .open.flags set to O_EXCL in there? Makes sense - it's about 3 years older than lookup_create() change. OK, then I'm going to remove the checks (treating condition as always true) and place BUG_ON for a few months just in case...