Skip to contentSkip to conversation

spi/spi_oc_tiny: fix build error

PATCH New Andres Salomon 3 participants 3 messages Feb 22, 2011 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi/spi_oc_tiny: fix build error

Fix the following build error due to a missing semicolon:

CC [M] drivers/spi/spi_oc_tiny.o
drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’ make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1

---
 drivers/spi/spi_oc_tiny.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spi_oc_tiny.c +1 -1
index e99e545..f1bde66 100644
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(struct platform_device *pdev)
 static const struct of_device_id tiny_spi_match[] = {
 	{ .compatible = "opencores,tiny-spi-rtlsvn2", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, tiny_spi_match);
 #else /* CONFIG_OF */
 #define tiny_spi_match NULL
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 spi/spi_oc_tiny and spi_altera.c: fix build errors

Quoted 7 lines · On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:

Fix the following build error due to a missing semicolon:

CC [M] drivers/spi/spi_oc_tiny.o
drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’ make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1

Same fix is needed for drivers/spi/spi_altera.c.
I already had this patch ready to send. Grant, can you extract the spi_altera.c patch...?

---
From: Randy Dunlap <[email protected]>

Fix build error due to missing semi-colon:

drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern' drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'

---
 drivers/spi/spi_altera.c  |    2 +-
 drivers/spi/spi_oc_tiny.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi_oc_tiny.c +1 -1
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
 static const struct of_device_id tiny_spi_match[] = {
 	{ .compatible = "opencores,tiny-spi-rtlsvn2", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, tiny_spi_match);
 #else /* CONFIG_OF */
 #define tiny_spi_match NULL
drivers/spi/spi_altera.c +1 -1
@@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
 static const struct of_device_id altera_spi_match[] = {
 	{ .compatible = "ALTR,spi-1.0", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, altera_spi_match);
 #else /* CONFIG_OF */
 #define altera_spi_match NULL
#2 lore raw

Re: [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors

Quoted 8 lines · Randy Dunlap
Quoted 6 lines · On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:

Fix the following build error due to a missing semicolon:

 CC [M]  drivers/spi/spi_oc_tiny.o drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’ make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1

Quoted 7 lines
Quoted 1 line

Same fix is needed for drivers/spi/spi_altera.c.
I already had this patch ready to send.  Grant, can you extract the spi_altera.c patch...?

done. Will be pushed out when I finish testing.

g.

Quoted 40 lines

---
From: Randy Dunlap <[email protected]>

Fix build error due to missing semi-colon:

drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern' drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'

---
 drivers/spi/spi_altera.c  |    2 +-
 drivers/spi/spi_oc_tiny.c |    2 +-

 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi_oc_tiny.c +1 -1
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
  static const struct of_device_id tiny_spi_match[] = {
        { .compatible = "opencores,tiny-spi-rtlsvn2", },
        {},
-}
+};
  MODULE_DEVICE_TABLE(of, tiny_spi_match);
  #else /* CONFIG_OF */
  #define tiny_spi_match NULL
drivers/spi/spi_altera.c +1 -1
@@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
  static const struct of_device_id altera_spi_match[] = {
        { .compatible = "ALTR,spi-1.0", },
        {},
-}
+};
  MODULE_DEVICE_TABLE(of, altera_spi_match);
  #else /* CONFIG_OF */
  #define altera_spi_match NULL
Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.