Skip to contentSkip to conversation

gallium/nv50: use 0x8697 class on NVAF

PATCH In review Marcin Slusarz 2 participants 4 messages Feb 22, 2011 – Mar 7, 2011 3 messages not in the archive

lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw

PATCH 1/1 gallium/nv50: use 0x8697 class on NVAF

Addresses: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-nouveau/+bug/723012

Reported-and-tested-by: Alan Pope

---
 src/gallium/drivers/nv50/nv50_reg.h    |    4 ++++
 src/gallium/drivers/nv50/nv50_screen.c |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)
src/gallium/drivers/nv50/nv50_reg.h +4 -0
index 949838b..90d77e5 100644
@@ -1685,6 +1685,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 
 
+#define NVAFTCL										0x00008697
+
+
+
 #define NV50_COMPUTE									0x000050c0
 
 #define  NV50_COMPUTE_NOP								0x00000100
src/gallium/drivers/nv50/nv50_screen.c +3 -0
index edc3d54..8069509 100644
@@ -389,6 +389,9 @@ nv50_screen_create(struct pipe_winsys *ws, struct nouveau_device *dev)
 		case 0xac:
 			tesla_class = NVA0TCL;
 			break;
+		case 0xaf:
+			tesla_class = NVAFTCL;
+			break;
 		default:
 			tesla_class = NVA8TCL;
 			break;
Signature · 1 line
1.7.4.rc3
author
#2 lore raw
In reply to a message not in the archive
Quoted 40 lines · Marcin Slusarz

Addresses: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-nouveau/+bug/723012

Reported-and-tested-by: Alan Pope

---
 src/gallium/drivers/nv50/nv50_reg.h    |    4 ++++
 src/gallium/drivers/nv50/nv50_screen.c |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)
src/gallium/drivers/nv50/nv50_reg.h +4 -0
index 949838b..90d77e5 100644
@@ -1685,6 +1685,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 
 
+#define NVAFTCL										0x00008697
+
+
+
 #define NV50_COMPUTE									0x000050c0
 
 #define  NV50_COMPUTE_NOP								0x00000100
src/gallium/drivers/nv50/nv50_screen.c +3 -0
index edc3d54..8069509 100644
@@ -389,6 +389,9 @@ nv50_screen_create(struct pipe_winsys *ws, struct nouveau_device *dev)
 		case 0xac:
 			tesla_class = NVA0TCL;
 			break;
+		case 0xaf:
+			tesla_class = NVAFTCL;
+			break;
 		default:
 			tesla_class = NVA8TCL;
 			break;
Signature · 1 line
1.7.4.rc3

ping

if it's wrong for some reason, just say so...

#4 lore raw
In reply to a message not in the archive
Quoted 44 lines · Marcin Slusarz
Quoted 31 lines · Marcin Slusarz

Addresses: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-nouveau/+bug/723012

Reported-and-tested-by: Alan Pope
---
 src/gallium/drivers/nv50/nv50_reg.h    |    4 ++++ src/gallium/drivers/nv50/nv50_screen.c |    3 +++

 2 files changed, 7 insertions(+), 0 deletions(-)
src/gallium/drivers/nv50/nv50_reg.h +4 -0
index 949838b..90d77e5 100644
@@ -1685,6 +1685,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 
 
+#define NVAFTCL                                                                              0x00008697
+
+
+
  #define NV50_COMPUTE                                                                 0x000050c0
 
  #define  NV50_COMPUTE_NOP                                                            0x00000100
src/gallium/drivers/nv50/nv50_screen.c +0 -0
index edc3d54..8069509 100644
@@ -389,6 +389,9 @@ nv50_screen_create(struct pipe_winsys *ws, struct nouveau_device *dev)

              case 0xac:
                      tesla_class = NVA0TCL;
                      break;

Quoted 9 lines

+             case 0xaf:
+                     tesla_class = NVAFTCL;
+                     break;
              default:
                      tesla_class = NVA8TCL;
                      break;
--
1.7.4.rc3

ping

Quoted 7 lines

if it's wrong for some reason, just say so...

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

The patch seems ok to me, the nitpicker in me would tell you to separate the reported by and tested by tags and include Alan Pope's email address :)

Signature · 2 lines
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.
author
#6 lore raw
In reply to a message not in the archive
Quoted 45 lines · Maarten Maathuis
Quoted 44 lines · Marcin Slusarz
Quoted 31 lines · Marcin Slusarz

Addresses: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-nouveau/+bug/723012

Reported-and-tested-by: Alan Pope
---
 src/gallium/drivers/nv50/nv50_reg.h    |    4 ++++ src/gallium/drivers/nv50/nv50_screen.c |    3 +++

 2 files changed, 7 insertions(+), 0 deletions(-)
src/gallium/drivers/nv50/nv50_reg.h +4 -0
index 949838b..90d77e5 100644
@@ -1685,6 +1685,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 
 
+#define NVAFTCL                                                                              0x00008697
+
+
+
  #define NV50_COMPUTE                                                                 0x000050c0
 
  #define  NV50_COMPUTE_NOP                                                            0x00000100
src/gallium/drivers/nv50/nv50_screen.c +0 -0
index edc3d54..8069509 100644
@@ -389,6 +389,9 @@ nv50_screen_create(struct pipe_winsys *ws, struct nouveau_device *dev)

              case 0xac:
                      tesla_class = NVA0TCL;
                      break;

Quoted 9 lines

+             case 0xaf:
+                     tesla_class = NVAFTCL;
+                     break;
              default:
                      tesla_class = NVA8TCL;
                      break;
--
1.7.4.rc3

ping

Quoted 7 lines
Quoted 2 lines

if it's wrong for some reason, just say so...

The patch seems ok to me, the nitpicker in me would tell you to separate the reported by and tested by tags and include Alan Pope's email address :)

Christoph already fixed it in his big "nv50: replace most of it with nvc0 driver ported to nv50" commit.

Thanks for a review anyway :),
Marcin
_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau