Skip to contentSkip to conversation

iwlwifi: remove duplicate initialization

PATCH In review Dan Carpenter 2 participants 2 messages Feb 26, 2011

Subsystems (2)
Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 iwlwifi: remove duplicate initialization

rate_mask is initialized again later so this can be removed. Btw, if rate_control_send_low(sta, priv_sta, txrc) returns false, that means that "sta" is non-NULL. That's why the second initialization of rate_mask is a little simpler than the first.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/iwlegacy/iwl-3945-rs.c +1 -1
index 4fabc54..977bd24 100644
@@ -644,7 +644,7 @@ static void iwl3945_rs_get_rate(void *priv_r, struct ieee80211_sta *sta,
 	u32 fail_count;
 	s8 scale_action = 0;
 	unsigned long flags;
-	u16 rate_mask = sta ? sta->supp_rates[sband->band] : 0;
+	u16 rate_mask;
 	s8 max_rate_idx = -1;
 	struct iwl_priv *priv __maybe_unused = (struct iwl_priv *)priv_r;
 	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dan Carpenter

rate_mask is initialized again later so this can be removed. Btw, if rate_control_send_low(sta, priv_sta, txrc) returns false, that means that "sta" is non-NULL. That's why the second initialization of rate_mask is a little simpler than the first.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Wey-Yi Guy <[email protected]>

make sense

Wey