nilfs_cleanerd not started for mount with relative pathname

Hi,

when testing my other patches, the following came up:

with absolute pathname:

# mount /dev/sdb2 /mnt/x
# ps ax | grep [n]ilfs_cleanerd
30408 ?        Ss     0:00 /sbin/nilfs_cleanerd -n /dev/sdb2 /mnt/x

with relative mountpoint pathname:

# umount /mnt/x
# cd /mnt
# mount /dev/sdb2 x
# ps ax | grep [n]ilfs_cleanerd
((no such process))

with relative device pathname:

# umount /mnt/x
# cd /dev
# mount sdb2 /mnt/x
# ps ax | grep [n]ilfs_cleanerd
((no such process))

This is due to chdir(ROOTDIR) in daemonize(); currently daemonize is always called with nochdir == 0. Should I hardcode it to nochdir == 1 or canonicalize the dev' and dir' arguments with myrealpath()?

Quoted 25 lines · dexen deVries

Hi,

when testing my other patches, the following came up:

with absolute pathname:

# mount /dev/sdb2 /mnt/x
# ps ax | grep [n]ilfs_cleanerd
30408 ?        Ss     0:00 /sbin/nilfs_cleanerd -n /dev/sdb2 /mnt/x

with relative mountpoint pathname:

# umount /mnt/x
# cd /mnt
# mount /dev/sdb2 x
# ps ax | grep [n]ilfs_cleanerd
((no such process))

with relative device pathname:

# umount /mnt/x
# cd /dev
# mount sdb2 /mnt/x
# ps ax | grep [n]ilfs_cleanerd
((no such process))

Quoted 3 lines

This is due to chdir(ROOTDIR) in daemonize(); currently daemonize is always called with nochdir == 0. Should I hardcode it to nochdir == 1 or canonicalize the dev' and dir' arguments with myrealpath()?

It sounds like cleanerd needs a fix.
I'll take a look and answer to you tomorrow.

Thanks,
Ryusuke Konishi

canonicalize pathnames of device & directory before daemonize() to support relative pathnames

Signed-off-by dexen deVries <[email protected]>

---
 sbin/cleanerd/cleanerd.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

sbin/cleanerd/cleanerd.c +7 -0

index 1f03cfb..3d58916 100644
@@ -1343,6 +1343,7 @@ static int nilfs_cleanerd_clean_loop(struct nilfs_cleanerd *cleanerd)
 int main(int argc, char *argv[])
 {
 	char *progname, *conffile;
+	char canonical[PATH_MAX + 2];
 	const char *dev, *dir;
 	char *endptr;
 	int status, nofork, c;

@@ -1406,6 +1407,12 @@ int main(int argc, char *argv[])
 	if (optind < argc)
 		dir = argv[optind++];
 
+	if (dev && myrealpath(dev, canonical, sizeof(canonical)))
+		dev = strdup(canonical);
+
+	if (dir && myrealpath(dir, canonical, sizeof(canonical)))
+		dir = strdup(canonical);
+
 	if (daemonize(0, 0, nofork) < 0) {
 		fprintf(stderr, "%s: %s\n", progname, strerror(errno));
 		exit(1);

Signature · 6 lines

1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html