Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
PATCH 1/15 Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
The alsactl binary is often installed in /usr/sbin instead of /sbin (not a necessity to start up the system). Used in distributions such as Gentoo, Slackware and Arch.
--- policy/modules/admin/alsa.fc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/admin/alsa.fc +1 -0
@@ -8,6 +8,7 @@ HOME_DIR/\.asoundrc -- gen_context(system_u:object_r:alsa_home_t,s0) /etc/asound\.state -- gen_context(system_u:object_r:alsa_etc_rw_t,s0) /sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) +/usr/sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) /sbin/salsa -- gen_context(system_u:object_r:alsa_exec_t,s0) /usr/bin/ainit -- gen_context(system_u:object_r:alsa_exec_t,s0)
Signature · 1 line
1.7.3.4
PATCH 1/15 Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
Local symlink ? Or at least ifdef in the file context file ? I mean if refpolicy has to cater for every single case of different location for every different distribution or installation...
Quoted 21 lines · Sven Vermeulen
The alsactl binary is often installed in
/usr/sbininstead of /sbin (not a necessity to start up the system). Used in distributions such as Gentoo, Slackware and Arch.Signed-off-by Sven Vermeulen <[email protected]>--- policy/modules/admin/alsa.fc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)policy/modules/admin/alsa.fc +1
-0@@ -8,6 +8,7 @@ HOME_DIR/\.asoundrc -- gen_context(system_u:object_r:alsa_home_t,s0) /etc/asound\.state -- gen_context(system_u:object_r:alsa_etc_rw_t,s0) /sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) +/usr/sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) /sbin/salsa -- gen_context(system_u:object_r:alsa_exec_t,s0) /usr/bin/ainit -- gen_context(system_u:object_r:alsa_exec_t,s0)
PATCH 1/15 Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
Quoted 3 lines · Guido Trentalancia
Local symlink ? Or at least ifdef in the file context file ? I mean if refpolicy has to cater for every single case of different location for every different distribution or installation...
I agree, but I think that /usr/sbin/alsactl is the correct location (as alsa is not a prerequisite in order to succesfully boot a system, so no requirement to be in /sbin). It is also used by various distributions, not just one.
If the reference policy wants to be consistent in its file context definitinos, it should base this on something, not on the first one who suggested a location.
I try to only suggest file context definitions that are matched by
- a purely single distribution (with an ifdef)
- several (at least 3) distributions (which are not related to each other)
- upstream (for instance locations documented by the package itself)
If it is not the intention to have a functional file context, but rather inform policy developers on how it could be (i.e. know that the alsactl binary should be alsa_exec_t) that's fine with me too - just say it ;-)
Wkr,
Sven Vermeulen
PATCH 1/15 Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
Quoted 9 lines · Sven Vermeulen
Quoted 3 lines · Guido Trentalancia
Local symlink ? Or at least ifdef in the file context file ? I mean if refpolicy has to cater for every single case of different location for every different distribution or installation...
I agree, but I think that
/usr/sbin/alsactlis the correct location (as alsa is not a prerequisite in order to succesfully boot a system, so no requirement to be in /sbin). It is also used by various distributions, not just one.
Proposing that to the alsa project itself ? Just another idea to avoid the duplicate...
The point is that it is core (although not "vital") system functionality (userspace interface to a main kernel module). So hypothetically my vote on whether that should be /usr/sbin rather than /sbin would be neutral.
Quoted 20 lines
If the reference policy wants to be consistent in its file context definitinos, it should base this on something, not on the first one who suggested a location.
I try to only suggest file context definitions that are matched by
- a purely single distribution (with an ifdef)
- several (at least 3) distributions (which are not related to each other)
- upstream (for instance locations documented by the package itself)If it is not the intention to have a functional file context, but rather inform policy developers on how it could be (i.e. know that the alsactl binary should be
alsa_exec_t) that's fine with me too - just say it ;-)Wkr,
Sven Vermeulen
_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy
PATCH 1/15 Support /usr/sbin/alsactl location too (fex. Gentoo, Slackware, Arch)
In reply to Sven VermeulenQuoted 14 lines · Sven Vermeulen
The alsactl binary is often installed in
/usr/sbininstead of /sbin (not a necessity to start up the system). Used in distributions such as Gentoo, Slackware and Arch.Signed-off-by Sven Vermeulen <[email protected]>--- policy/modules/admin/alsa.fc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)policy/modules/admin/alsa.fc +0
-0
policy/modules/admin/alsa.fc HOME_DIR/\.asoundrc -- gen_context(system_u:object_r:alsa_home_t,s0) · line 14
Quoted 7 lines
policy/modules/admin/alsa.fc +1
-0@@ -8,6 +8,7 @@ HOME_DIR/\.asoundrc -- gen_context(system_u:object_r:alsa_home_t,s0) /etc/asound\.state -- gen_context(system_u:object_r:alsa_etc_rw_t,s0) /sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) +/usr/sbin/alsactl -- gen_context(system_u:object_r:alsa_exec_t,s0) /sbin/salsa -- gen_context(system_u:object_r:alsa_exec_t,s0) /usr/bin/ainit -- gen_context(system_u:object_r:alsa_exec_t,s0)
Merged.
Signature · 3 lines
Chris PeBenito Tresys Technology, LLC www.tresys.com | oss.tresys.com