Skip to contentSkip to conversation

hardcoded delimiter in mlmmj-process.c?

mlmmj Moritz Wilhelmy 2 participants 2 messages Mar 12, 2011

lore
Share & tools
lore
#0 lore raw

Dear list,

Today, I found some references to listname-moderators@listdomain by accident, but the delimiter is +.
From mlmmj-1.2.17.1/src/mlmmj-process.c:127 (139 in tip), it seems this is hardcoded to -:

Quoted 1 line

to = concatstr(3, listname, "-moderators@", listfqdn); /* FIXME JFA: Should this be converted? Why, why not? */

This baffled me a bit. It says FIXME, but not what is subject to be fixed. Assuming that the FIXME is about the minus, I don't see why it should *not* be changed to use the same delimiter that's used everywhere else...

Best regards,

Moritz

#1 lore raw
Quoted 5 lines · Moritz Wilhelmy

Dear list,

Today, I found some references to listname-moderators@listdomain by accident, but the delimiter is +.

Quoted 1 line

From mlmmj-1.2.17.1/src/mlmmj-process.c:127 (139 in tip), it seems this

Quoted 8 lines

is hardcoded to -:

Quoted 1 line

to = concatstr(3, listname, "-moderators@", listfqdn); /* FIXME JFA: Should this be converted? Why, why not? */

This baffled me a bit. It says FIXME, but not what is subject to be fixed. Assuming that the FIXME is about the minus, I don't see why it should *not* be changed to use the same delimiter that's used everywhere else...

I haven't checked the sources, but I think this is one of those "doesn't matter" situations, because +moderators (or -moderators for that matter) doesn't actually do anything. I.e. there is no functionality in Mlmmj that forwards a mail to list+moderators to the moderators of the list. It's just used as a placeholder in the To: header of moderation messages for the sake of having *something* there. It probably should be something more like

listname moderators :;

i.e. use some text describing the group it's being sent to, but not list any of the addresses, or anything that looks like an address but isn't, explicitly.

Ben.