iwlwifi: remove duplicate initialization in

PATCH In review Dan Carpenter 2 participants 2 messages Mar 15, 2011

Subsystems (2)

Kernel janitors Networking drivers (wireless)

lore

Share & tools

lore

Dan Carpenter

author

2011-03-15 07:03 UTC #0 lore raw

PATCH 2/2 iwlwifi: remove duplicate initialization in

We initialize exit_pending twice. It's the second initialization which is correct. That was added in d745d472af "iwlwifi: cancel scan when down the device".

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/wireless/iwlwifi/iwl-agn.c +1 -1

index 321b18b..7adc60e 100644
@@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
 static void __iwl_down(struct iwl_priv *priv)
 {
 	unsigned long flags;
-	int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
+	int exit_pending;
 
 	IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");

Guy, Wey-Yi

Acked-by on v1 2/2

2011-03-15 09:05 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

We initialize exit_pending twice. It's the second initialization which is correct. That was added in d745d472af "iwlwifi: cancel scan when down the device".
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Wey-Yi Guy <[email protected]>

Quoted 13 lines

drivers/net/wireless/iwlwifi/iwl-agn.c +1 -1

index 321b18b..7adc60e 100644
@@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
 static void __iwl_down(struct iwl_priv *priv)
 {
 	unsigned long flags;
-	int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
+	int exit_pending;
 
 	IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");