efivars: memory leak on error in create_efivars_bin_attributes()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 18, 2011 Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2011-03-18 07:12 UTC #0 lore raw

PATCH 1/2 efivars: memory leak on error in create_efivars_bin_attributes()

This is a cut and paste bug. We intended to free ->del_var and ->new_var but we only free ->new_var.

Signed-off-by Dan Carpenter <[email protected]>

drivers/firmware/efivars.c +2 -2

index ff0c373..ff2fe40 100644
@@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars)
 
 	return 0;
 out_free:
-	kfree(efivars->new_var);
-	efivars->new_var = NULL;
+	kfree(efivars->del_var);
+	efivars->del_var = NULL;
 	kfree(efivars->new_var);
 	efivars->new_var = NULL;
 	return error;

Mike Waychison

Acked-by on v1 1/2

2011-03-18 09:23 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

This is a cut and paste bug. We intended to free ->del_var and ->new_var but we only free ->new_var.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Mike Waychison <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html