Skip to contentSkip to conversation

Bad bug in remote logging

DISCUSSION Steve Grubb 3 participants 4 messages Apr 11, 2011 – Apr 12, 2011

lore
Share & tools
lore
#0 lore raw

Hello,

There was a bug reported to day that I think merits an email and/or discussion.

https://bugzilla.redhat.com/show_bug.cgi?id=695419
=================================
audisp-remote does

Quoted 4 lines
              memset (&address, 0, sizeof(address));
              address.sin_family = htons(AF_INET);
              address.sin_port = htons(config.local_port);
              address.sin_addr.s_addr = htonl(INADDR_ANY);

which shows in strace as

Quoted 1 line

bind(3, {sa_family=0x200 /* AF_??? */, sa_data="\0<\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) =

0

For some reason the call still succeeds, but a correct invocation would not call htons on AF_INET.
================================

The reason it succeeds is because there is a matching mistake in auditd. So, what this means is that remote logging is not using IPv4, but something else. I committed a patch to fix this in trunk:

https://fedorahosted.org/audit/changeset/505

This would cause new systems and old systems to not be able to talk to one another. Regarding RHEL, remote logging has been tech preview, meaning that its alpha code and likely buggy but available so you can see where this is heading. So, I think we can just change it to be correct. For Fedora, there is no tech preview and everything is supported...but it has a short life. However, what the code was doing is clearly wrong. So, I am thinking to fix this all the way back to F-13 if I can. Regarding other distributions...not sure what the support status is or how they would like to choose to solve this. Anyone have any thoughts on this?

-Steve

#1 lore raw
Quoted 11 lines · Steve Grubb

Hello,

There was a bug reported to day that I think merits an email and/or discussion.

https://bugzilla.redhat.com/show_bug.cgi?id=695419
=================================
audisp-remote does

Quoted 4 lines
              memset (&address, 0, sizeof(address));
              address.sin_family = htons(AF_INET);
              address.sin_port = htons(config.local_port);
              address.sin_addr.s_addr = htonl(INADDR_ANY);
Quoted 7 lines

which shows in strace as

Quoted 1 line

bind(3, {sa_family=0x200 /* AF_??? */, sa_data="\0<\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) =

0

For some reason the call still succeeds, but a correct invocation would not call htons on AF_INET.

Are you sure that that field is actually used by bind()? Doesn't the socket also have the address family? Its surprising that the call would succeed and even more surprising that the socket would work.

Quoted 3 lines

================================

The reason it succeeds is because there is a matching mistake in auditd. So, what this means is that remote logging is not using IPv4, but something else.

What else would it be using? That value is greater than any legal address family so I would think that lots of things in the kernel would break.

Quoted 5 lines

I committed a patch to fix this in trunk:

https://fedorahosted.org/audit/changeset/505

This would cause new systems and old systems to not be able to talk to one another. Regarding RHEL, remote logging has been tech preview, meaning that its alpha code and likely buggy but available so you can see where this is heading. So, I think we can just change it to be correct. For Fedora, there is no tech preview and everything is supported...but it has a short life. However, what the code was doing is clearly wrong. So, I am thinking to fix this all the way back to F-13 if I can. Regarding other distributions...not sure what the support status is or how they would like to choose to solve this. Anyone have any thoughts on this?

Your resolution seems ok if this is really more than a benign coding problem.

-- ljk

Quoted 7 lines

-Steve

--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit

#2 lore raw

Am Dienstag, 12. April 2011, um 05:18:44 schrieb Linda Knippers:

Hi Linda,

Quoted 15 lines
Quoted 14 lines · Steve Grubb

Hello,

There was a bug reported to day that I think merits an email and/or discussion.

https://bugzilla.redhat.com/show_bug.cgi?id=695419
=================================
audisp-remote does

Quoted 4 lines
              memset (&address, 0, sizeof(address));
              address.sin_family = htons(AF_INET);
              address.sin_port = htons(config.local_port);
              address.sin_addr.s_addr = htonl(INADDR_ANY);
Quoted 4 lines
Quoted 4 lines

which shows in strace as

Quoted 2 lines

bind(3, {sa_family=0x200 /* AF_??? */,
sa_data="\0<\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) =

Bind does not do anything with the family - it just calls the bind callback function set for the protocol by the socket syscall. What is the socket syscall saying here?

Note that the socket syscall (specifically __sock_create) has the following code for the family:

        if (family < 0 || family >= NPROTO)
                return -EAFNOSUPPORT;

And NPROTO is defined as decimal 39 (in 2.6.38). Hence, 0x200 as a family does not work for socket - the socket syscall would have returned an error.

If for some reason the socket syscall uses AF_INET and diverts into IPv4, sin_family does not seem to be used unless you have a socket-specific bind function (e.g. RAW sockets).

To make a final determination on the impact, I would check:

- strace for socket syscall

- tcpdump on the connection

Ciao
Stephan

#3 lore raw
Quoted 19 lines · Stephan Mueller

Am Dienstag, 12. April 2011, um 05:18:44 schrieb Linda Knippers:

Hi Linda,

Quoted 15 lines
Quoted 14 lines · Steve Grubb

Hello,

There was a bug reported to day that I think merits an email and/or discussion.

https://bugzilla.redhat.com/show_bug.cgi?id=695419
=================================
audisp-remote does

Quoted 4 lines
              memset (&address, 0, sizeof(address));
              address.sin_family = htons(AF_INET);
              address.sin_port = htons(config.local_port);
              address.sin_addr.s_addr = htonl(INADDR_ANY);
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

which shows in strace as

Quoted 2 lines

bind(3, {sa_family=0x200 /* AF_??? */,
sa_data="\0<\0\0\0\0\0\0\0\0\0\0\0\0"}, 16) =

Bind does not do anything with the family - it just calls the bind callback function set for the protocol by the socket syscall. What is the socket syscall saying here?

The socket call is correct.
socket (AF_INET, SOCK_STREAM, 0);

Quoted 6 lines

Note that the socket syscall (specifically __sock_create) has the following code for the family:

        if (family < 0 || family >= NPROTO)
                return -EAFNOSUPPORT;
Quoted 7 lines

And NPROTO is defined as decimal 39 (in 2.6.38). Hence, 0x200 as a family does not work for socket - the socket syscall would have returned an error.

If for some reason the socket syscall uses AF_INET and diverts into IPv4, sin_family does not seem to be used unless you have a socket-specific bind function (e.g. RAW sockets).

It seems that bind(2) is not using the family. I checked on a system that is fixed vs one that is not fixed. They both can transfer packets to one another. So, it looks like you are right and there is only cosmetic problem.

Quoted 5 lines

To make a final determination on the impact, I would check:

- strace for socket syscall

- tcpdump on the connection

These seem to be OK aside from strace not being able to decipher the family member to bind. However, the calls to bind and connect are successful.

-Steve