Skip to contentSkip to conversation

pr_debug usage in raw_sendmsg

DISCUSSION Dave Jones 2 participants 2 messages Apr 12, 2011

Subsystems (3)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

While working on my system call fuzzer, I keep getting a lot of spew in dmesg from raw_sendmsg. Particularly..

[ 6442.690780] no dev
[ 6454.257701] msg_flags 0x00000080
[ 8055.873142] msg->msg_flags = 0xd63f35c1

Is there a good reason for keeping -DDEBUG in net/ieee802154/Makefile ?

Those messages don't look particularly helpful given there's no other context. (the 'no dev' one in particular looks kinda hopeless)

Dave

maintainer
#1 lore raw

From: Dave Jones <[email protected]>
Date: Tue, 12 Apr 2011 18:31:37 -0400

Quoted 11 lines

While working on my system call fuzzer, I keep getting a lot of spew in dmesg from raw_sendmsg. Particularly..

[ 6442.690780] no dev
[ 6454.257701] msg_flags 0x00000080
[ 8055.873142] msg->msg_flags = 0xd63f35c1

Is there a good reason for keeping -DDEBUG in net/ieee802154/Makefile ?

Those messages don't look particularly helpful given there's no other context. (the 'no dev' one in particular looks kinda hopeless)

All of those cflags modifications in net/ieee802154/Makefile are bogus, I'll commit the following:

--------------------
ieee802154: Remove hacked CFLAGS in net/ieee802154/Makefile

It adds -Wall (which the kernel carefully controls already) and of all things -DDEBUG (which should be set by other means if desired, please we have dynamic-debug these days).

Kill this noise.

---
 net/ieee802154/Makefile |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
net/ieee802154/Makefile +0 -2
index ce2d335..5761185 100644
@@ -1,5 +1,3 @@
 obj-$(CONFIG_IEEE802154) +=	ieee802154.o af_802154.o
 ieee802154-y		:= netlink.o nl-mac.o nl-phy.o nl_policy.o wpan-class.o
 af_802154-y		:= af_ieee802154.o raw.o dgram.o
-
-ccflags-y += -Wall -DDEBUG
Signature · 1 line
1.7.4.3