Skip to contentSkip to conversation

Distro policy ?

DISCUSSION Wolfgang Denk 8 participants 11 messages Apr 14, 2011 – Apr 20, 2011

lore
Share & tools
lore
#0 lore raw

HI,

we're trying to build our own distribution based on Yocto 1.0. We would like to push all modifications / extensions and our distro stuff upstream into the mainline repository, but we are not sure what is the best way to do this:

So far we have put our distro-related changes into a separate layer but it seems that it was not so good idea: it looks like bitbake can't include files from one layer to another and we have to copy includes even if we don't want to change them.

Putting our changes back into the main layer would be pretty trivial, but it appears that current tendency is to move all distribution-specific things to their respective layers (like the poky distro configuration itself was moved to the meta-yocto layer).

So, from the policy side I think we should go with our own layer. On the technical side I'm disappointed with this 'include' problem: I find it rather impractical to copy things we don't want to change and just want to use from one layer to another and then having to keep these in sync with mainline.

What is the recommended way to address this issue?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
How come everyone's going so slow if it's called rush hour?
#1 lore raw
Quoted 7 lines · Wolfgang Denk

HI,

we're trying to build our own distribution based on Yocto 1.0. We would like to push all modifications / extensions and our distro stuff upstream into the mainline repository, but we are not sure what is the best way to do this:

Quoted 5 lines

So far we have put our distro-related changes into a separate layer but it seems that it was not so good idea: it looks like bitbake can't include files from one layer to another and we have to copy includes even if we don't want to change them.

Wolfgang,

I would like to get more details about which include files (.incs) you are needing to modify. I know that there was some discussion at ELC this week about similar issues. I also know that we have a "Layering Tools" item on the 1.1 feature list to address these issues.

Quoted 5 lines

Putting our changes back into the main layer would be pretty trivial, but it appears that current tendency is to move all distribution-specific things to their respective layers (like the poky distro configuration itself was moved to the meta-yocto layer).

Correct, the core is supposed to be clean and distributions are supposed to be in layers. Your layer can be linked to or hosted on the git.yoctoproject.org site if you would like. Pulling distro specific changes into core is not appropriate. If you have generic changes to core that would be appropriate to all distro, we would consider them.

Quoted 8 lines

So, from the policy side I think we should go with our own layer. On the technical side I'm disappointed with this 'include' problem: I find it rather impractical to copy things we don't want to change and just want to use from one layer to another and then having to keep these in sync with mainline.

What is the recommended way to address this issue?

For the short term, I think that you may need to deal with the copy issue, until we have tooling in place.

I know this is not the answer you wanted to hear right now, we know about the issue and are looking at it.

Sau!

Quoted 4 lines

Best regards,

Wolfgang Denk

#2 lore raw
Quoted 5 lines · Saul Wold
Quoted 5 lines

So, from the policy side I think we should go with our own layer. On the technical side I'm disappointed with this 'include' problem: I find it rather impractical to copy things we don't want to change and just want to use from one layer to another and then having to keep these in sync with mainline.

There's no reason you should have to copy unmodified files from one layer to another, ever. Configuration files are found via BBPATH when they're referenced via a relative path, and file:// files via FILESPATH are easily dealt with as well. The only time you should have to copy is if you have a need to modify them, particularly as there's no "bbappend" that corresponds to recipe .inc files. Is there a particular case you're thinking of here?

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#3 lore raw
Quoted 7 lines · Chris Larson
Quoted 5 lines · Saul Wold
Quoted 5 lines

So, from the policy side I think we should go with our own layer. On the technical side I'm disappointed with this 'include' problem: I find it rather impractical to copy things we don't want to change and just want to use from one layer to another and then having to keep these in sync with mainline.

Quoted 7 lines

There's no reason you should have to copy unmodified files from one layer to another, ever. Configuration files are found via BBPATH when they're referenced via a relative path, and file:// files via FILESPATH are easily dealt with as well. The only time you should have to copy is if you have a need to modify them, particularly as there's no "bbappend" that corresponds to recipe .inc files. Is there a particular case you're thinking of here?

I guess he was talking about
require/include some.inc
used in recipe

Then I had to copy some.inc to same folder there my recipe is. Even when it's used in same path relative to layer top dir

Regards,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 16 lines · Martin Jansa
Quoted 7 lines · Chris Larson
Quoted 5 lines · Saul Wold
Quoted 5 lines

So, from the policy side I think we should go with our own layer. On the technical side I'm disappointed with this 'include' problem: I find it rather impractical to copy things we don't want to change and just want to use from one layer to another and then having to keep these in sync with mainline.

Quoted 7 lines

There's no reason you should have to copy unmodified files from one layer to another, ever.  Configuration files are found via BBPATH when they're referenced via a relative path, and file:// files via FILESPATH are easily dealt with as well.  The only time you should have to copy is if you have a need to modify them, particularly as there's no "bbappend" that corresponds to recipe .inc files.  Is there a particular case you're thinking of here?

Quoted 6 lines

I guess he was talking about
require/include some.inc
used in recipe

Then I had to copy some.inc to same folder there my recipe is. Even when it's used in same path relative to layer top dir

Change the recipe to use require/include recipes/foo/bar.inc, relative to the top of the entry in BBPATH.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#5 lore raw

Hi Chris,

Quoted 9 lines · Chris Larson
Quoted 6 lines

I guess he was talking about
require/include some.inc
used in recipe

Then I had to copy some.inc to same folder there my recipe is. Even when it's used in same path relative to layer top dir

Change the recipe to use require/include recipes/foo/bar.inc, relative to the top of the entry in BBPATH.

Yes, that's exactly the situation we have. Thanks for the tip!

Regards, Ilya.

#6 lore raw
In reply to Saul Wold

Hi Saul,

Quoted 4 lines · Saul Wold

I would like to get more details about which include files (.incs) you are needing to modify. I know that there was some discussion at ELC this week about similar issues. I also know that we have a "Layering Tools" item on the 1.1 feature list to address these issues.

We had one problem with the recipes that need to include files from the main layer. Thanks to the guy now I know that I just need to use the full path to solve this.
Another problem was a strange one. It was about poky's distro includes. When I started working on our distro I've just copied conf/distro/poky.conf to our new layer with new name and changed it a bit. This worked but I got a bunch of warnings about multiply providers. Then I've copied the conf/distro/include directory into our layer and all these warnings gone. Unfortunately I can't reproduce this behavior any more.

So, it looks like we have solved the problem with includes and now we are fine with our own layer.

Thanks for your help, guys!

Regards, Ilya.

#7 lore raw
In reply to Wolfgang Denk
Quoted 11 lines · Wolfgang Denk

HI,

we're trying to build our own distribution based on Yocto 1.0. We would like to push all modifications / extensions and our distro stuff upstream into the mainline repository, but we are not sure what is the best way to do this:

So far we have put our distro-related changes into a separate layer but it seems that it was not so good idea: it looks like bitbake can't include files from one layer to another and we have to copy includes even if we don't want to change them.

You can you just have to use a path from the top of the BBPATH entry for the layer you're using, so in our meta-demo layer I've used entries like:

require recipes-graphics/clutter/clutter.inc

to use an inc file from meta in Poky.

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Build System Monkey
        Intel Open Source Technology Centre
#8 lore raw

How about when it's the other way round -- you need to modify just the .inc for your layer, and not the recipes that require/include them? Should all recipes in the core be changed to use the path name syntax to enable that?

Thanks,
-Matt

Quoted 23 lines · Joshua Lock
Quoted 11 lines · Wolfgang Denk

HI,

we're trying to build our own distribution based on Yocto 1.0. We would like to push all modifications / extensions and our distro stuff upstream into the mainline repository, but we are not sure what is the best way to do this:

So far we have put our distro-related changes into a separate layer but it seems that it was not so good idea: it looks like bitbake can't include files from one layer to another and we have to copy includes even if we don't want to change them.

You can you just have to use a path from the top of the BBPATH entry for the layer you're using, so in our meta-demo layer I've used entries like:

require recipes-graphics/clutter/clutter.inc

to use an inc file from meta in Poky.

Cheers,
Joshua

#9 lore raw
Quoted 3 lines · Matt Madison

How about when it's the other way round -- you need to modify just the .inc for your layer, and not the recipes that require/include them? Should all recipes in the core be changed to use the path name syntax to enable that?

Yes, I think this sounds like its causing a few people problems and we should be using that syntax by default.

Cheers,

Richard

#10 lore raw
In reply to Joshua Lock

Hi Joshua,

Quoted 6 lines · Joshua Lock
Quoted 4 lines

So far we have put our distro-related changes into a separate layer but it seems that it was not so good idea: it looks like bitbake can't include files from one layer to another and we have to copy includes even if we don't want to change them.

You can you just have to use a path from the top of the BBPATH entry for

Thanks for the advice, this really does help.

Regards, Ilya.