Skip to contentSkip to conversation

xfs: fix compiler warning in xfs_trace.h

PATCH In review Christoph Hellwig 2 participants 2 messages Apr 24, 2011 – Apr 28, 2011 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: fix compiler warning in xfs_trace.h

xfs_fsblock_t may be a 32-bit type on if XFS_BIG_BLKNOS is not set, make sure to cast a value of this type to an unsigned long long before using the ll printk qualifier.

fs/xfs/linux-2.6/xfs_trace.h +1 -1
Index: xfs/fs/xfs/linux-2.6/xfs_trace.h
===================================================================
@@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
 		  __entry->wasfromfl,
 		  __entry->isfl,
 		  __entry->userdata,
-		  __entry->firstblock)
+		  (unsigned long long)__entry->firstblock)
 )
 
 #define DEFINE_ALLOC_EVENT(name) \

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Christoph Hellwig

xfs_fsblock_t may be a 32-bit type on if XFS_BIG_BLKNOS is not set, make sure to cast a value of this type to an unsigned long long before using the ll printk qualifier.

Index: xfs/fs/xfs/linux-2.6/xfs_trace.h
===================================================================

fs/xfs/linux-2.6/xfs_trace.h DECLARE_EVENT_CLASS(xfs_alloc_class, · line 1424

Quoted 8 lines
fs/xfs/linux-2.6/xfs_trace.h +1 -1
@@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
 		  __entry->wasfromfl,
 		  __entry->isfl,
 		  __entry->userdata,
-		  __entry->firstblock)
+		  (unsigned long long)__entry->firstblock)
 )
 
 #define DEFINE_ALLOC_EVENT(name) \
Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs