Skip to contentSkip to conversation

virtio_balloon: disable oom killer when fill balloon

PATCH Superseded Dave Young 2 participants 5 messages Apr 26, 2011

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 1/2 virtio_balloon: disable oom killer when fill balloon

When memory pressure is high, virtio ballooning will probably cause oom killing. Even if alloc_page with GFP_NORETRY itself does not directly trigger oom it will make memory becoming low then memory alloc of other processes will trigger oom killing. It is not desired behaviour.

Here disable oom killer in fill_balloon to address this issue.

---
 drivers/virtio/virtio_balloon.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/virtio/virtio_balloon.c +3 -0
@@ -25,6 +25,7 @@
 #include <linux/freezer.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/oom.h>
 
 struct virtio_balloon
 {
@@ -102,6 +103,7 @@ static void fill_balloon(struct virtio_b
 	/* We can only do one array worth at a time. */
 	num = min(num, ARRAY_SIZE(vb->pfns));
 
+	oom_killer_disable();
 	for (vb->num_pfns = 0; vb->num_pfns < num; vb->num_pfns++) {
 		struct page *page = alloc_page(GFP_HIGHUSER | __GFP_NORETRY |
 					__GFP_NOMEMALLOC | __GFP_NOWARN);
@@ -119,6 +121,7 @@ static void fill_balloon(struct virtio_b
 		vb->num_pages++;
 		list_add(&page->lru, &vb->pages);
 	}
+	oom_killer_enable();
 
 	/* Didn't get any?  Oh well. */
 	if (vb->num_pfns == 0)
#1 lore raw
Quoted 23 lines

When memory pressure is high, virtio ballooning will probably cause oom killing. Even if alloc_page with GFP_NORETRY itself does not directly trigger oom it will make memory becoming low then memory alloc of other processes will trigger oom killing. It is not desired behaviour.

Here disable oom killer in fill_balloon to address this issue.

---
 drivers/virtio/virtio_balloon.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/virtio/virtio_balloon.c +1 -0
@@ -25,6 +25,7 @@
 #include <linux/freezer.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/oom.h>
 
 struct virtio_balloon
 {

drivers/virtio/virtio_balloon.c static void fill_balloon(struct virtio_b · line 106

Quoted 4 lines
drivers/virtio/virtio_balloon.c +1 -0
@@ -102,6 +103,7 @@ static void fill_balloon(struct virtio_b
 	/* We can only do one array worth at a time. */
 	num = min(num, ARRAY_SIZE(vb->pfns));
 
+	oom_killer_disable();

I think this patch need proper comment at least. My first impression is, "Hm, __GFP_NORETRY should prevent oom, why is this necessary?". So, this actually prevent _another_ thread call out_of_memory(). Also, Here doesn't have any exclusion against hibernation (ie another oom_killer_disable() callsite). It should be described why lock is unnecessary.

Thanks.

Quoted 16 lines
drivers/virtio/virtio_balloon.c +1 -1
 	for (vb->num_pfns = 0; vb->num_pfns < num; vb->num_pfns++) {
 		struct page *page = alloc_page(GFP_HIGHUSER | __GFP_NORETRY |
 					__GFP_NOMEMALLOC | __GFP_NOWARN);
@@ -119,6 +121,7 @@ static void fill_balloon(struct virtio_b
 		vb->num_pages++;
 		list_add(&page->lru, &vb->pages);
 	}
+	oom_killer_enable();
 
 	/* Didn't get any?  Oh well. */
 	if (vb->num_pfns == 0)
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

author
#2 lore raw
Quoted 26 lines · KOSAKI Motohiro
Quoted 26 lines

When memory pressure is high, virtio ballooning will probably cause oom killing. Even if alloc_page with GFP_NORETRY itself does not directly trigger oom it will make memory becoming low then memory alloc of other processes will trigger oom killing. It is not desired behaviour.

Here disable oom killer in fill_balloon to address this issue.

---
 drivers/virtio/virtio_balloon.c |    3 +++

 1 file changed, 3 insertions(+)
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
@@ -25,6 +25,7 @@
  #include <linux/freezer.h>
  #include <linux/delay.h>
  #include <linux/slab.h>
+#include <linux/oom.h>
 

 struct virtio_balloon
 {

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +0 -0
@@ -102,6 +103,7 @@ static void fill_balloon(struct virtio_b
       /* We can only do one array worth at a time. */
       num = min(num, ARRAY_SIZE(vb->pfns));
 
Quoted 5 lines

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 static void fill_balloon(struct virtio_b · line 106

Quoted 1 line
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
+     oom_killer_disable();

I think this patch need proper comment at least. My first impression is, "Hm, __GFP_NORETRY should prevent oom, why is this necessary?". So, this actually prevent _another_ thread call out_of_memory().

Thanks, will fix.

Quoted 3 lines

Also, Here doesn't have any exclusion against hibernation (ie another oom_killer_disable() callsite). It should be described why lock is unnecessary.

Good catch, but lock should better be handled in oom_killer_disable function itself,
What do you think?

For oom killer multi user there's more problem, if process A disable oom killer then Process B enable oom killer, it is not A want to see, Any thoughts?

Quoted 24 lines

Thanks.

Quoted 16 lines
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +0 -0
       for (vb->num_pfns = 0; vb->num_pfns < num; vb->num_pfns++) {

              struct page *page = alloc_page(GFP_HIGHUSER | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN);

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -1
@@ -119,6 +121,7 @@ static void fill_balloon(struct virtio_b
               vb->num_pages++;
               list_add(&page->lru, &vb->pages);
       }
+     oom_killer_enable();
 
       /* Didn't get any?  Oh well. */
       if (vb->num_pfns == 0)
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 2 lines
Regards
dave
#3 lore raw
Quoted 40 lines
Quoted 26 lines · KOSAKI Motohiro
Quoted 26 lines

When memory pressure is high, virtio ballooning will probably cause oom killing. Even if alloc_page with GFP_NORETRY itself does not directly trigger oom it will make memory becoming low then memory alloc of other processes will trigger oom killing. It is not desired behaviour.

Here disable oom killer in fill_balloon to address this issue.

---
 drivers/virtio/virtio_balloon.c |    3 +++

 1 file changed, 3 insertions(+)
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
@@ -25,6 +25,7 @@
  #include <linux/freezer.h>
  #include <linux/delay.h>
  #include <linux/slab.h>
+#include <linux/oom.h>
 

 struct virtio_balloon
 {

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +0 -0
@@ -102,6 +103,7 @@ static void fill_balloon(struct virtio_b
       /* We can only do one array worth at a time. */
       num = min(num, ARRAY_SIZE(vb->pfns));
 
Quoted 5 lines

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 static void fill_balloon(struct virtio_b · line 106

Quoted 1 line
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
+     oom_killer_disable();

I think this patch need proper comment at least. My first impression is, "Hm, __GFP_NORETRY should prevent oom, why is this necessary?". So, this actually prevent _another_ thread call out_of_memory().

Thanks, will fix.

Quoted 3 lines

Also, Here doesn't have any exclusion against hibernation (ie another oom_killer_disable() callsite). It should be described why lock is unnecessary.

Quoted 7 lines

Good catch, but lock should better be handled in oom_killer_disable function itself,
What do you think?

For oom killer multi user there's more problem, if process A disable oom killer then Process B enable oom killer, it is not A want to see, Any thoughts?

If baloon and hibernation don't have any implicit exclusion, you are right.

Sorry, I don't virtio internal. please don't ask me.

author
#4 lore raw
Quoted 44 lines · KOSAKI Motohiro
Quoted 44 lines
Quoted 26 lines · KOSAKI Motohiro
Quoted 26 lines

When memory pressure is high, virtio ballooning will probably cause oom killing. Even if alloc_page with GFP_NORETRY itself does not directly trigger oom it will make memory becoming low then memory alloc of other processes will trigger oom killing. It is not desired behaviour.

Here disable oom killer in fill_balloon to address this issue.

---
 drivers/virtio/virtio_balloon.c |    3 +++

 1 file changed, 3 insertions(+)
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
@@ -25,6 +25,7 @@
  #include <linux/freezer.h>
  #include <linux/delay.h>
  #include <linux/slab.h>
+#include <linux/oom.h>
 

 struct virtio_balloon
 {

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +0 -0
@@ -102,6 +103,7 @@ static void fill_balloon(struct virtio_b
       /* We can only do one array worth at a time. */
       num = min(num, ARRAY_SIZE(vb->pfns));
 
Quoted 5 lines

drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 static void fill_balloon(struct virtio_b · line 106

Quoted 1 line
drivers/virtio/virtio_balloon.c 2011-04-26 11:38:43.979785141 +0800 renamed from drivers/virtio/virtio_balloon.c    2010-10-13 10:14:38.000000000 +0800 +1 -0
+     oom_killer_disable();

I think this patch need proper comment at least. My first impression is, "Hm, __GFP_NORETRY should prevent oom, why is this necessary?". So, this actually prevent _another_ thread call out_of_memory().

Thanks, will fix.

Quoted 3 lines

Also, Here doesn't have any exclusion against hibernation (ie another oom_killer_disable() callsite). It should be described why lock is unnecessary.

Good catch, but lock should better be handled in oom_killer_disable function itself,
What do you think?

Quoted 6 lines
Quoted 3 lines

For oom killer multi user there's more problem, if process A disable oom killer then Process B enable oom killer, it is not A want to see, Any thoughts?

If baloon and hibernation don't have any implicit exclusion, you are right.

For this case, hibernation will freeze balloon thread before call oom_killer_disable, so there's no problem.

If we consider future users of oom_killer_disabled, we will have to deal with it.

Quoted 6 lines

Sorry, I don't virtio internal. please don't ask me.

Signature · 2 lines
Regards
dave