LED Status APIs

Hi,

i'm currently developing a BSP for the Buffalo LS-XHL (ARM based) and stumble across the two LED APIs.

Is there any particular reason to have two different APIs? I guess an ARM BSP has to support both? Eg. the 'classic status API' is used in cmd_ide.c for example and the ARM one is used in arm startup code.

Michael

Dear Michael Walle,

Actually none of them is really needed. If you don't have any explicit requirements to provide certain feedback or status information though LEDs, then just omit this alltogether.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra

Hi Wolfgang,

Am Montag 02 Mai 2011, 22:36:22 schrieb Wolfgang Denk:

I certainly need some indicator because the board doesn't have any serial output.

Would it make sense to unify that APIs into a single one? Any thoughts on that?

Michael

CONFIG_STATUS_LED is the common API people should migrate to

if your LED's are simply connected to a GPIO, and your arch supports the generic GPIO framework, then the work is done for you already. look at the logic in include/configs/bf526-ezbrd.h as an example. that is the only board- specific code needed.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110502/e6b3c6ee/attachment.pgp