2.6.39-rc6: cdrecord oops

DISCUSSION Alexey Dobriyan 2 participants 3 messages May 4, 2011 SCSI

Share & tools

Linus Torvalds

2011-05-04 19:33 UTC #1 lore raw

Quoted 7 lines · Alexey Dobriyan

Got one at the very end of burning session (haven't tried to reproduce yet). Apparently happened when cdrecord tried to open the door.
__lock_acquire
lock_acquire
_raw_spin_lock_irq
blk_get_request

Hmm. That would be the

  spin_lock_irq(q->queue_lock);

in there, I'm not seeing any other spinlock.

Quoted 12 lines

scsi_execute
scsi_set_medium_removal
sr_lock_door
cdrom_release
sr_block_release
__blk_dev_put
blkdev_put
blkdev_close
fput
filp_close
sys_close

Quoted 4 lines

comm: cdrecord
RAX was small number like 0x46(?)
RBX 6b6b6b6b6b6b6b83
RDI 6b6b6b6b6b6b6b83

And that implies that 'q' has been free'd before it's used, and you have SLUB-debugging turned on.

Quoted 1 line

This model is USB device.

Hmm. It looks a bit odd that cdrom_release() does the ->release call before it does the ->tray_move thing, but I don't think that's it.

Jens/James: What's the sequence to blk_cleanup_queue() for a SCSI CD-ROM? It really does look like we're releasing the queue before we're done with it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Alexey Dobriyan

author

2011-05-04 19:46 UTC #2 lore raw

Quoted 35 lines · Linus Torvalds

Quoted 7 lines · Alexey Dobriyan
Got one at the very end of burning session (haven't tried to reproduce yet). Apparently happened when cdrecord tried to open the door.
__lock_acquire
lock_acquire
_raw_spin_lock_irq
blk_get_request
Hmm. That would be the
  spin_lock_irq(q->queue_lock);
in there, I'm not seeing any other spinlock.
Quoted 12 lines
scsi_execute
scsi_set_medium_removal
sr_lock_door
cdrom_release
sr_block_release
__blk_dev_put
blkdev_put
blkdev_close
fput
filp_close
sys_close
Quoted 4 lines
comm: cdrecord
RAX was small number like 0x46(?)
RBX 6b6b6b6b6b6b6b83
RDI 6b6b6b6b6b6b6b83
And that implies that 'q' has been free'd before it's used, and you have SLUB-debugging turned on.

Quoted 8 lines

Quoted 1 line
This model is USB device.
Hmm. It looks a bit odd that cdrom_release() does the ->release call before it does the ->tray_move thing, but I don't think that's it.
Jens/James: What's the sequence to blk_cleanup_queue() for a SCSI CD-ROM? It really does look like we're releasing the queue before we're done with it.

Second time, burning finished to the end successfully.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html