net: ipv6: mcast: Removing invalid check

Since the variable 'first' is assigned to 1, the check "if (truncate && !first)" will always be false.

Thanks to Coverity for spotting this issue.

Signed-off-by Maxin B. John <[email protected]>

---

net/ipv6/mcast.c +0 -2

index 76b8937..441c1a4 100644
@@ -1536,8 +1536,6 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ifmcaddr6 *pmc,
 
 		if (AVAILABLE(skb) < sizeof(*psrc) +
 		    first*sizeof(struct mld2_grec)) {
-			if (truncate && !first)
-				break;	 /* truncate these */
 			if (pgr)
 				pgr->grec_nsrcs = htons(scount);
 			if (skb)

I don't see that. We are within a 'for' loop, and some lines below you will find an assignment of 'first = 0;'.

Since the variable 'first' is assigned to 1, the check "if (truncate && !first)" will always be false.

Thanks to Coverity for spotting this issue.

Signed-off-by Maxin B. John <[email protected]>

---

net/ipv6/mcast.c +0 -0

index 76b8937..441c1a4 100644

At a first glance, I would say Coverity is wrong, unless you can explain why it's right ;)

first can be 0 at this point, we are in a loop.

BTW "Removing invalid check" is a really wrong patch title.

Once you can prove your point, you should use "Remove useless check"