Skip to contentSkip to conversation

gpio: gpio-exynos4 build fails in mainline

DISCUSSION Randy Dunlap 5 participants 7 messages May 29, 2011 – May 30, 2011 GPIO

lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

on x86_64

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

author
#1 lore raw
Quoted 9 lines · On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

on x86_64

---

similarly:

drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

author
#2 lore raw
Quoted 8 lines · On Sun, 29 May 2011 08:35:20 -0700 Randy Dunlap wrote:
Quoted 6 lines · On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

Quoted 7 lines
Quoted 3 lines

on x86_64

---

similarly:

drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'

and

drivers/gpio/gpio-s5pc100.c:21:11: error: unable to open 'mach/map.h'

(this began as x86_64 allmodconfig)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#3 lore raw
Quoted 19 lines · On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:
Quoted 8 lines · On Sun, 29 May 2011 08:35:20 -0700 Randy Dunlap wrote:
Quoted 6 lines · On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

Quoted 7 lines
Quoted 3 lines

on x86_64

---

similarly:

drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'

Quoted 6 lines

and

drivers/gpio/gpio-s5pc100.c:21:11: error: unable to open 'mach/map.h'

(this began as x86_64 allmodconfig)

and

drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#4 lore raw
Quoted 23 lines · Randy Dunlap
Quoted 21 lines · On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:
Quoted 8 lines · On Sun, 29 May 2011 08:35:20 -0700 Randy Dunlap wrote:
Quoted 6 lines · On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

Quoted 7 lines
Quoted 3 lines

on x86_64

---

similarly:

drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'

and

Quoted 8 lines
Quoted 4 lines

drivers/gpio/gpio-s5pc100.c:21:11: error: unable to open 'mach/map.h'

(this began as x86_64 allmodconfig)

and

drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'

Hi,

Right, now it's just moved from mach directories to drivers/gpio So it requires the proper depends on each ARCH_CPU.

Thank you,
Kyungmin Park
---

drivers/gpio/Kconfig +4 -0
index 5923976..655babf 100644
@@ -88,24 +88,28 @@ config GPIO_IT8761E
 
 config GPIO_EXYNOS4
        bool "Samsung Exynos4 GPIO library support"
+       depends on CPU_EXYNOS4210
        default y if CPU_EXYNOS4210
        help
          Say yes here to support Samsung Exynos4 series SoCs GPIO library
 
 config GPIO_PLAT_SAMSUNG
        bool "Samsung SoCs GPIO library support"
+       depends on SAMSUNG_GPIOLIB_4BIT
        default y if SAMSUNG_GPIOLIB_4BIT
        help
          Say yes here to support Samsung SoCs GPIO library
 
 config GPIO_S5PC100
        bool "Samsung S5PC100 GPIO library support"
+       depends on CPU_S5PC100
        default y if CPU_S5PC100
        help
          Say yes here to support Samsung S5PC100 SoCs GPIO library
 
 config GPIO_S5PV210
        bool "Samsung S5PV210/S5PC110 GPIO library support"
+       depends on CPU_S5PV210
        default y if CPU_S5PV210
        help
          Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
Quoted 11 lines

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code *** --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#5 lore raw
Quoted 2 lines · Kyungmin Park
Quoted 1 line · Randy Dunlap

On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:

(snip)

Quoted 3 lines
Quoted 2 lines

drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'

Hi all,

Grrr, :(

Quoted 5 lines

Hi,

Right, now it's just moved from mach directories to drivers/gpio So it requires the proper depends on each ARCH_CPU.

Please add me in Cc on this.

drivers/gpio/Kconfig config GPIO_IT8761E · line 94

Quoted 13 lines

---

drivers/gpio/Kconfig +1 -0
index 5923976..655babf 100644
@@ -88,24 +88,28 @@ config GPIO_IT8761E
 
  config GPIO_EXYNOS4
         bool "Samsung Exynos4 GPIO library support"
+       depends on CPU_EXYNOS4210
         default y if CPU_EXYNOS4210
         help
           Say yes here to support Samsung Exynos4 series SoCs GPIO library

Basically, GPIO_EXYNOS4 is used only for EXYNOS4(EXYNOS4210) and was selected as a default on EXYNOS4 before moving into drivers/. I mean, do we really need to select this manually in kernel configuration(like make menuconfig)?

And I think, it's more reasonable that depends on ARCH_XXX not CPU_XXX.

Grant, how about following?

+config GPIO_EXYNOS4
+ bool
+ depends on ARCH_EXYNOS4
+ default y if CPU_EXYNOS4210

drivers/gpio/Kconfig config GPIO_IT8761E · line 102

Quoted 8 lines
drivers/gpio/Kconfig +1 -0
  config GPIO_PLAT_SAMSUNG
         bool "Samsung SoCs GPIO library support"
+       depends on SAMSUNG_GPIOLIB_4BIT
         default y if SAMSUNG_GPIOLIB_4BIT
         help
           Say yes here to support Samsung SoCs GPIO library

Same as above.

+config GPIO_PLAT_SAMSUNG
+ bool
+ depends on PLAT_SAMSUNG
+ default y if SAMSUNG_GPIOLIB_4BIT

drivers/gpio/Kconfig config GPIO_IT8761E · line 109

Quoted 7 lines
drivers/gpio/Kconfig +1 -0
  config GPIO_S5PC100
         bool "Samsung S5PC100 GPIO library support"
+       depends on CPU_S5PC100
         default y if CPU_S5PC100
         help
           Say yes here to support Samsung S5PC100 SoCs GPIO library

Same...

+config GPIO_S5PC100
+ bool
+ depends on ARCH_S5PC100
+ default y if CPU_S5PC100

drivers/gpio/Kconfig config GPIO_IT8761E

Quoted 7 lines
drivers/gpio/Kconfig +1 -0
  config GPIO_S5PV210
         bool "Samsung S5PV210/S5PC110 GPIO library support"
+       depends on CPU_S5PV210
         default y if CPU_S5PV210
         help
           Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library

Same.

+config GPIO_S5PV210
+ bool
+ depends on ARCH_S5PV210
+ default y if CPU_S5PV210

One more, IMHO, would be better if they could not split like following. As you know, 'PLAT_SAMSUNG' includes common GPIOlib for other Samsung SoCs.

config GPIO_PLAT_SAMSUNG
...
config GPIO_S5PC100
...
config GPIO_S5PV210
...
config GPIO_EXYNOS4
...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#6 lore raw
In reply to Kyungmin Park
Quoted 33 lines · Kyungmin Park
Quoted 23 lines · Randy Dunlap
Quoted 21 lines · On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:
Quoted 8 lines · On Sun, 29 May 2011 08:35:20 -0700 Randy Dunlap wrote:
Quoted 6 lines · On Sun, 29 May 2011 08:30:32 -0700 Randy Dunlap wrote:

probably should depend on ARM or some ARM sub-arch/mach-type?

drivers/gpio/gpio-exynos4.c:18:11: error: unable to open 'mach/map.h'

Quoted 7 lines
Quoted 3 lines

on x86_64

---

similarly:

drivers/gpio/gpio-plat-samsung.c:22:11: error: unable to open 'plat/gpio-core.h'

and

Quoted 8 lines
Quoted 4 lines

drivers/gpio/gpio-s5pc100.c:21:11: error: unable to open 'mach/map.h'

(this began as x86_64 allmodconfig)

and

drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'

Quoted 7 lines

Hi,

Right, now it's just moved from mach directories to drivers/gpio So it requires the proper depends on each ARCH_CPU.

Thank you,
Kyungmin Park

A variant on this patch merged and pushed out to the following branch. Thanks.

git://git.secretlab.ca/git/linux-2.6 gpio/merge

It should be in linux-next tomorrow.

g.

Quoted 46 lines

---

drivers/gpio/Kconfig +4 -0
index 5923976..655babf 100644
@@ -88,24 +88,28 @@ config GPIO_IT8761E
 
 config GPIO_EXYNOS4
        bool "Samsung Exynos4 GPIO library support"
+       depends on CPU_EXYNOS4210
        default y if CPU_EXYNOS4210
        help
          Say yes here to support Samsung Exynos4 series SoCs GPIO library
 
 config GPIO_PLAT_SAMSUNG
        bool "Samsung SoCs GPIO library support"
+       depends on SAMSUNG_GPIOLIB_4BIT
        default y if SAMSUNG_GPIOLIB_4BIT
        help
          Say yes here to support Samsung SoCs GPIO library
 
 config GPIO_S5PC100
        bool "Samsung S5PC100 GPIO library support"
+       depends on CPU_S5PC100
        default y if CPU_S5PC100
        help
          Say yes here to support Samsung S5PC100 SoCs GPIO library
 
 config GPIO_S5PV210
        bool "Samsung S5PV210/S5PC110 GPIO library support"
+       depends on CPU_S5PV210
        default y if CPU_S5PV210
        help
          Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
Quoted 12 lines

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code *** --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/