Skip to contentSkip to conversation

drivers/gpio changes for SMBIOS and System Firmware

RFC PATCH In review Prarit Bhargava 2 participants 3 messages May 31, 2011 GPIO

lore
Share & tools
lore
#0 lore raw

RFC PATCH 9/35 drivers/gpio changes for SMBIOS and System Firmware

drivers/gpio changes for SMBIOS and System Firmware

---
 drivers/gpio/basic_mmio_gpio.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/gpio/basic_mmio_gpio.c +0 -1
index 8152e9f..6664e3d 100644
@@ -59,7 +59,6 @@ o        `                     ~~~~\___/~~~~    ` controller in FPGA is ,.`
 #include <linux/gpio.h>
 #include <linux/slab.h>
 #include <linux/platform_device.h>
-#include <linux/mod_devicetable.h>
 #include <linux/basic_mmio_gpio.h>
 
 static void bgpio_write8(void __iomem *reg, unsigned long data)
Signature · 1 line
1.7.5.1
#1 lore raw

Hi Prarit

I could use some background on why the mod_devicetable.h include is being removed from basic_mmio_gpio (need a commit description). Also, any reason why this change isn't squashed in the patch that necessitates it?

g.

Quoted 1 line · Prarit Bhargava
Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
#2 lore raw
Quoted 4 lines · Grant Likely

Hi Prarit

I could use some background on why the mod_devicetable.h include is being removed from basic_mmio_gpio (need a commit description).

Grant, this was part of a cleanup of the dmi* code. Currently DMI* (which have now been changed to SYSFW*) definitions are in mod_devicetable.h. AFAICT, mod_devicetable.h is not needed in the gpio file.

Quoted 4 lines

Also,
any reason why this change isn't squashed in the patch that necessitates it?

Purely organization of the patchset -- the SYSFW & SMBIOS code touches close to 180 different files. I decided that a directory-by-directory breakout of the drivers/* patches was the best way to go.

P.

Quoted 8 lines

g.

Quoted 1 line · Prarit Bhargava