Skip to contentSkip to conversation

libxl: use '-name' instead of deprecated '-domain-name' for device model

PATCH In review Wei Liu 3 participants 6 messages Jun 7, 2011

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 libxl: use '-name' instead of deprecated '-domain-name' for device model

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb

Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

libxl: use '-name' instead of deprecated '-domain-name' for device model.

This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +1 -1
index 47a51c8..d53a20d 100644
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                       "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
     if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
 
     if (info->vnc) {
         char *vncarg;
#1 lore raw
Quoted 15 lines · Wei Liu

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb

Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

libxl: use '-name' instead of deprecated '-domain-name' for device model.

This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +0 -0
index 47a51c8..d53a20d 100644

tools/libxl/libxl_dm.c static char ** libxl__build_device_model_args_old(libxl__gc *gc, · line 101

Quoted 8 lines
tools/libxl/libxl_dm.c +1 -1
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                       "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
     if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
 
     if (info->vnc) {
         char *vncarg;

considering that libxl__build_device_model_args_old is only meant to be used with the old qemu-xen that we are not going to upgrade anymore, I don't think it is worth to try to update its command line options.

author
#2 lore raw
Quoted 22 lines · Stefano Stabellini
Quoted 21 lines · Wei Liu

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

    libxl: use '-name' instead of deprecated '-domain-name' for device model.

    This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +1 -1
index 47a51c8..d53a20d 100644
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                        "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
      if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
Quoted 7 lines

tools/libxl/libxl_dm.c static char ** libxl__build_device_model_args_old(libxl__gc *gc, · line 101

Quoted 2 lines
tools/libxl/libxl_dm.c +0 -0
      if (info->vnc) {
          char *vncarg;

considering that libxl__build_device_model_args_old is only meant to be used with the old qemu-xen that we are not going to upgrade anymore, I don't think it is worth to try to update its command line options.

Well, the device_model_{override,version} are not working for pv now. So I consider this patch a workaround for using upstream qemu as pure pv backend.

I'm still waiting for IanJ's re-factoring of libxl. Hope that could get a better implementation.

#3 lore raw
Quoted 32 lines · Wei Liu
Quoted 22 lines · Stefano Stabellini
Quoted 21 lines · Wei Liu

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

    libxl: use '-name' instead of deprecated '-domain-name' for device model.

    This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +1 -1
index 47a51c8..d53a20d 100644
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                        "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
      if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
Quoted 7 lines

tools/libxl/libxl_dm.c static char ** libxl__build_device_model_args_old(libxl__gc *gc, · line 101

Quoted 2 lines
tools/libxl/libxl_dm.c +0 -0
      if (info->vnc) {
          char *vncarg;

considering that libxl__build_device_model_args_old is only meant to be used with the old qemu-xen that we are not going to upgrade anymore, I don't think it is worth to try to update its command line options.

Quoted 7 lines

Well, the device_model_{override,version} are not working for pv now. So I consider this patch a workaround for using upstream qemu as pure pv backend.

I'm still waiting for IanJ's re-factoring of libxl. Hope that could get a better implementation.

IanJ is not going to touch this code AFAIK, so you can go ahead and write a proper patch for that.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

author
#4 lore raw
In reply to Stefano Stabellini
Quoted 22 lines · Stefano Stabellini
Quoted 21 lines · Wei Liu

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb

Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

libxl: use '-name' instead of deprecated '-domain-name' for device model.

This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +1 -1
index 47a51c8..d53a20d 100644
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                       "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
     if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
Quoted 6 lines

tools/libxl/libxl_dm.c static char ** libxl__build_device_model_args_old(libxl__gc *gc, · line 101

Quoted 2 lines
tools/libxl/libxl_dm.c +0 -0
     if (info->vnc) {
         char *vncarg;

considering that libxl__build_device_model_args_old is only meant to be used with the old qemu-xen that we are not going to upgrade anymore, I don't think it is worth to try to update its command line options.

Well, device_model_{override,version} are not working for pure pv. I consider this patch a workaround for using upstream qemu as pure pv backend.

I hope that IanJ's re-factoring of libxl will get a better implementation of this.

#5 lore raw
Quoted 23 lines · Wei Liu
Quoted 22 lines · Stefano Stabellini
Quoted 21 lines · Wei Liu

commit 6c744543757f0769e5a8f49ab0d8a01538357fbb

Author: Wei Liu <[email protected]>
Date:   Tue Jun 7 14:26:34 2011 +0800

libxl: use '-name' instead of deprecated '-domain-name' for device model.

This unifies upstream qemu and Xen's qemu-dm startup option.

Signed-off-by Wei Liu <[email protected]>
tools/libxl/libxl_dm.c +1 -1
index 47a51c8..d53a20d 100644
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
                       "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
 
     if (info->dom_name)
-        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
Quoted 8 lines
Quoted 6 lines

tools/libxl/libxl_dm.c static char ** libxl__build_device_model_args_old(libxl__gc *gc, · line 101

Quoted 2 lines
tools/libxl/libxl_dm.c +0 -0
     if (info->vnc) {
         char *vncarg;

considering that libxl__build_device_model_args_old is only meant to be used with the old qemu-xen that we are not going to upgrade anymore, I don't think it is worth to try to update its command line options.

Well, device_model_{override,version} are not working for pure pv.

I think it would be preferable to tackle this directly rather than working around it.

Quoted 6 lines

I
consider this patch a workaround for using upstream qemu as pure pv backend.

I hope that IanJ's re-factoring of libxl will get a better implementation of this.

I wasn't aware of any intention (by IanJ or otherwise) to refactor anything in this particular area.

Ian.