Skip to contentSkip to conversation

pull request: bluetooth-2.6 2011-06-08

DISCUSSION Gustavo F. Padovan 2 participants 5 messages Jun 8, 2011 – Jun 10, 2011 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

Hi John,

First round of fixed for 3.0! There are here a regression fix for 1.1 and earlier devices and a fix in the shutdown of SCO sockets. Other 3 patches are warning shut up. And one byte leak to userspace fix.

Please pull, thanks!

The following changes since commit 51e65257142a87fe46a1ce5c35c86c5baf012614:

iwlegacy: fix channel switch locking (2011-06-08 14:19:05 -0400)

are available in the git repository at:
master.kernel.org:/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git master

David Miller (2):
Bluetooth: Do not ignore errors returned from strict_strtol()
Bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()

Filip Palian (1):
Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

Luiz Augusto von Dentz (1):
Bluetooth: fix shutdown on SCO sockets

Stephen Boyd (1):
Bluetooth: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning

Ville Tervo (1):
Bluetooth: Do not send SET_EVENT_MASK for 1.1 and earlier devices

 drivers/bluetooth/btmrvl_debugfs.c |   12 ++++++++++++
 net/bluetooth/cmtp/capi.c          |    3 +--
 net/bluetooth/hci_event.c          |   18 ++++++++++--------
 net/bluetooth/l2cap_sock.c         |    1 +
 net/bluetooth/rfcomm/sock.c        |    4 +++-
 net/bluetooth/sco.c                |   13 ++++++++++++-
 6 files changed, 39 insertions(+), 12 deletions(-)

Gustavo

#1 lore raw
Quoted 17 lines · Gustavo F. Padovan

Hi John,

First round of fixed for 3.0! There are here a regression fix for 1.1 and earlier devices and a fix in the shutdown of SCO sockets. Other 3 patches are warning shut up. And one byte leak to userspace fix.

Please pull, thanks!

The following changes since commit 51e65257142a87fe46a1ce5c35c86c5baf012614:

iwlegacy: fix channel switch locking (2011-06-08 14:19:05 -0400)

are available in the git repository at:
master.kernel.org:/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git master

David Miller (2):

...

Quoted 1 line

Bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()

Well, the patch submitter sounds familiar. :-) But killing an unused variable isn't a bug fix. It doesn't do any damage, but I suspect that Dave expects to be held to the same standards as everyone else.

Can you drop that one (and reapply it for 3.1)? Sorry for the trouble...

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#2 lore raw
Quoted 21 lines · John W. Linville
Quoted 17 lines · Gustavo F. Padovan

Hi John,

First round of fixed for 3.0! There are here a regression fix for 1.1 and earlier devices and a fix in the shutdown of SCO sockets. Other 3 patches are warning shut up. And one byte leak to userspace fix.

Please pull, thanks!

The following changes since commit 51e65257142a87fe46a1ce5c35c86c5baf012614:

iwlegacy: fix channel switch locking (2011-06-08 14:19:05 -0400)

are available in the git repository at:
master.kernel.org:/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git master

David Miller (2):

...

Quoted 7 lines
Quoted 1 line

Bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()

Well, the patch submitter sounds familiar. :-) But killing an unused variable isn't a bug fix. It doesn't do any damage, but I suspect that Dave expects to be held to the same standards as everyone else.

Can you drop that one (and reapply it for 3.1)? Sorry for the trouble...

Sorry for that, I tough it was not that bad fix this for 3.0. New pull request follows. Thanks a lot!

The following changes since commit 51e65257142a87fe46a1ce5c35c86c5baf012614:

iwlegacy: fix channel switch locking (2011-06-08 14:19:05 -0400)

are available in the git repository at:
master.kernel.org:/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git master

David Miller (1):
Bluetooth: Do not ignore errors returned from strict_strtol()

Filip Palian (1):
Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

Luiz Augusto von Dentz (1):
Bluetooth: fix shutdown on SCO sockets

Stephen Boyd (1):
Bluetooth: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning

Ville Tervo (1):
Bluetooth: Do not send SET_EVENT_MASK for 1.1 and earlier devices

 drivers/bluetooth/btmrvl_debugfs.c |   12 ++++++++++++
 net/bluetooth/hci_event.c          |   18 ++++++++++--------
 net/bluetooth/l2cap_sock.c         |    1 +
 net/bluetooth/rfcomm/sock.c        |    4 +++-
 net/bluetooth/sco.c                |   13 ++++++++++++-
 5 files changed, 38 insertions(+), 10 deletions(-)

Gustavo

#3 lore raw
Quoted 10 lines · Gustavo F. Padovan
Quoted 8 lines · John W. Linville
Quoted 1 line · Gustavo F. Padovan

Bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()

Well, the patch submitter sounds familiar. :-) But killing an unused variable isn't a bug fix. It doesn't do any damage, but I suspect that Dave expects to be held to the same standards as everyone else.

Quoted 7 lines
Quoted 1 line

Can you drop that one (and reapply it for 3.1)? Sorry for the trouble...

Sorry for that, I tough it was not that bad fix this for 3.0. New pull request follows. Thanks a lot!

Stephen Boyd (1):
Bluetooth: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning

Sorry, I missed this one too -- can you redirect it for 3.1 as well?

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#4 lore raw
Quoted 13 lines · John W. Linville
Quoted 12 lines · Gustavo F. Padovan
Quoted 9 lines · John W. Linville
Quoted 1 line · Gustavo F. Padovan

Bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()

Well, the patch submitter sounds familiar. :-) But killing an unused variable isn't a bug fix. It doesn't do any damage, but I suspect that Dave expects to be held to the same standards as everyone else.

Can you drop that one (and reapply it for 3.1)? Sorry for the trouble...

Quoted 7 lines
Quoted 5 lines

Sorry for that, I tough it was not that bad fix this for 3.0. New pull request follows. Thanks a lot!

Stephen Boyd (1):
Bluetooth: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning

Sorry, I missed this one too -- can you redirect it for 3.1 as well?

The following changes since commit 51e65257142a87fe46a1ce5c35c86c5baf012614:

iwlegacy: fix channel switch locking (2011-06-08 14:19:05 -0400)

are available in the git repository at:
master.kernel.org:/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git master

David Miller (1):
Bluetooth: Do not ignore errors returned from strict_strtol()

Filip Palian (1):
Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

Luiz Augusto von Dentz (1):
Bluetooth: fix shutdown on SCO sockets

Ville Tervo (1):
Bluetooth: Do not send SET_EVENT_MASK for 1.1 and earlier devices

 drivers/bluetooth/btmrvl_debugfs.c |   12 ++++++++++++
 net/bluetooth/hci_event.c          |   18 ++++++++++--------
 net/bluetooth/l2cap_sock.c         |    1 +
 net/bluetooth/rfcomm/sock.c        |    1 +
 net/bluetooth/sco.c                |   13 ++++++++++++-
 5 files changed, 36 insertions(+), 9 deletions(-)

Gustavo