Skip to contentSkip to conversation

dma/ep93xx_dma.c: local symbols should be static

PATCH In review H Hartley Sweeten 3 participants 3 messages Jun 10, 2011 – Jun 16, 2011 dmaengine

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 dma/ep93xx_dma.c: local symbols should be static

The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver and should be marked static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Dan Williams <[email protected]>
Cc Vinod Koul <[email protected]>

---

drivers/dma/ep93xx_dma.c +1 -1
index 0766c1e..5d7a49b 100644
@@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
  *
  * Returns a valid DMA descriptor or %NULL in case of failure.
  */
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
 ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
 			   dma_addr_t src, size_t len, unsigned long flags)
 {
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · H Hartley Sweeten

The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver and should be marked static.

Signed-off-by H Hartley Sweeten <[email protected]>
Acked-by Mika Westerberg <[email protected]>
Quoted 18 lines
Cc Dan Williams <[email protected]>
Cc Vinod Koul <[email protected]>

---

drivers/dma/ep93xx_dma.c +1 -1
index 0766c1e..5d7a49b 100644
@@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
  *
  * Returns a valid DMA descriptor or %NULL in case of failure.
  */
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
 ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
 			   dma_addr_t src, size_t len, unsigned long flags)
 {
#2 lore raw
In reply to H Hartley Sweeten
Quoted 7 lines · H Hartley Sweeten

The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver and should be marked static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Dan Williams <[email protected]>
Cc Vinod Koul <[email protected]>

Applied Thanks

Quoted 21 lines

---

drivers/dma/ep93xx_dma.c +1 -2
index 0766c1e..5d7a49b 100644
@@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
  *
  * Returns a valid DMA descriptor or %NULL in case of failure.
  */
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
 ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
 			   dma_addr_t src, size_t len, unsigned long flags)
 {
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
~Vinod