Skip to contentSkip to conversation

fs/partitions/check.c: make local symbols static

PATCH Applied H Hartley Sweeten 3 participants 3 messages Jun 10, 2011 – Jun 13, 2011

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 fs/partitions/check.c: make local symbols static

The symbols part_ro_show, part_alignment_offset_show, and part_discard_alignment_show are not used outside this file and should be marked static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Yasuaki Ishimatsu <[email protected]>
Cc Alexey Dobriyan <[email protected]>
Cc Tejun Heo <[email protected]>

---

fs/partitions/check.c +6 -6
index d545e97..e3c63d1 100644
@@ -237,22 +237,22 @@ ssize_t part_size_show(struct device *dev,
 	return sprintf(buf, "%llu\n",(unsigned long long)p->nr_sects);
 }
 
-ssize_t part_ro_show(struct device *dev,
-		       struct device_attribute *attr, char *buf)
+static ssize_t part_ro_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
 {
 	struct hd_struct *p = dev_to_part(dev);
 	return sprintf(buf, "%d\n", p->policy ? 1 : 0);
 }
 
-ssize_t part_alignment_offset_show(struct device *dev,
-				   struct device_attribute *attr, char *buf)
+static ssize_t part_alignment_offset_show(struct device *dev,
+					  struct device_attribute *attr, char *buf)
 {
 	struct hd_struct *p = dev_to_part(dev);
 	return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset);
 }
 
-ssize_t part_discard_alignment_show(struct device *dev,
-				   struct device_attribute *attr, char *buf)
+static ssize_t part_discard_alignment_show(struct device *dev,
+					   struct device_attribute *attr, char *buf)
 {
 	struct hd_struct *p = dev_to_part(dev);
 	return sprintf(buf, "%u\n", p->discard_alignment);
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · H Hartley Sweeten

The symbols part_ro_show, part_alignment_offset_show, and part_discard_alignment_show are not used outside this file and should be marked static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Yasuaki Ishimatsu <[email protected]>
Cc Alexey Dobriyan <[email protected]>
Cc Tejun Heo <[email protected]>
Acked-by Tejun Heo <[email protected]>

Thanks.

Signature · 1 line
tejun
Applied
#2 lore raw
In reply to H Hartley Sweeten
Quoted 3 lines · H Hartley Sweeten

The symbols part_ro_show, part_alignment_offset_show, and part_discard_alignment_show are not used outside this file and should be marked static.

Applied, thanks.

Signature · 1 line
Jens Axboe