sun4m SMP: fix wrong shift instruction in IPI handler
PATCH 1/1 sun4m SMP: fix wrong shift instruction in IPI handler
This shift instruction appears to be shifting in the wrong direction. Without this change, my SparcStation-20MP hangs just after bringing up the second CPU:
Entering SMP Mode...
Starting CPU 2 at f02b4e90
Brought up 2 CPUs
Total of 2 processors activated (99.52 BogoMIPS).
*** stuck ***
--- arch/sparc/kernel/entry.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sparc/kernel/entry.S +1 -1
@@ -293,7 +293,7 @@ maybe_smp4m_msg: WRITE_PAUSE wr %l4, PSR_ET, %psr WRITE_PAUSE - sll %o3, 28, %o2 ! shift for simpler checks below + srl %o3, 28, %o2 ! shift for simpler checks below maybe_smp4m_msg_check_single: andcc %o2, 0x1, %g0 beq,a maybe_smp4m_msg_check_mask
From: Will Simoneau <[email protected]>
Date: Fri, 15 Jul 2011 23:05:15 -0400
Quoted 11 lines
This shift instruction appears to be shifting in the wrong direction. Without this change, my SparcStation-20MP hangs just after bringing up the second CPU:
Entering SMP Mode...
Starting CPU 2 atf02b4e90
Brought up 2 CPUs
Total of 2 processors activated (99.52 BogoMIPS).
*** stuck ***Signed-off-by Will Simoneau <[email protected]>
Applied, thanks a lot Will.
David Miller
maintainerFrom: David Miller <[email protected]>
Date: Sat, 16 Jul 2011 10:46:36 -0700 (PDT)
Quoted 13 lines
From: Will Simoneau <[email protected]>
Date: Fri, 15 Jul 2011 23:05:15 -0400Quoted 10 lines
This shift instruction appears to be shifting in the wrong direction. Without this change, my SparcStation-20MP hangs just after bringing up the second CPU:
Entering SMP Mode...
Starting CPU 2 atf02b4e90
Brought up 2 CPUs
Total of 2 processors activated (99.52 BogoMIPS).
*** stuck ***
Quoted 3 lines
Quoted 1 line
Signed-off-by Will Simoneau <[email protected]>Applied, thanks a lot Will.
BTW, in the future please post sparc patches to [email protected] so that they 1) go to the correct audience and 2) get tracked properly at patchwork.ozlabs.org
Thanks