Skip to contentSkip to conversation

x86, perf: P4 PMU - Fix typos in comments and style cleanup

PATCH In review Cyrill Gorcunov 1 participant 2 messages Jul 21, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, perf: P4 PMU - Fix typos in comments and style cleanup

This patch fixes typos in comments, renames obscure p4_event_alias::original and ::alter members to ::original and ::alternative as appropriate, and finally drops parenthesis from the return of p4_get_alias_event to fit coding style.

No functional changes.

---

 arch/x86/include/asm/perf_event_p4.h |    2 -
 arch/x86/kernel/cpu/perf_event_p4.c  |   66 +++++++++++++++--------------------
 2 files changed, 31 insertions(+), 37 deletions(-)
arch/x86/include/asm/perf_event_p4.h +1 -1
Index: linux-2.6.git/arch/x86/include/asm/perf_event_p4.h
===================================================================
@@ -133,7 +133,7 @@
 
 /*
  * In case of event aliasing we need to preserve some
- * caller bits otherwise the mapping won't be complete.
+ * caller bits, otherwise the mapping won't be complete.
  */
 #define P4_CONFIG_EVENT_ALIAS_MASK			  \
 	(p4_config_pack_escr(P4_CONFIG_MASK_ESCR)	| \
arch/x86/kernel/cpu/perf_event_p4.c +30 -36

114 lines not on this page · raw message

#1 lore raw
Commit-ID:  f53173e47dee5f7514d264796bec58d43ed0f67f
Gitweb:     http://git.kernel.org/tip/f53173e47dee5f7514d264796bec58d43ed0f67f
Author:     Cyrill Gorcunov <[email protected]>
AuthorDate: Thu, 21 Jul 2011 20:06:25 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 21 Jul 2011 20:41:54 +0200

x86, perf: P4 PMU - Fix typos in comments and style cleanup

This patch:

- fixes typos in comments and clarifies the text
- renames obscure p4_event_alias::original and ::alter members to ::original and ::alternative as appropriate
- drops parenthesis from the return of p4_get_alias_event()

No functional changes.

---
 arch/x86/include/asm/perf_event_p4.h |    2 +-
 arch/x86/kernel/cpu/perf_event_p4.c  |   66 +++++++++++++++------------------
 2 files changed, 31 insertions(+), 37 deletions(-)
arch/x86/include/asm/perf_event_p4.h +1 -1
index 4d86c86..4f7e67e 100644
@@ -133,7 +133,7 @@
 
 /*
  * In case of event aliasing we need to preserve some
- * caller bits otherwise the mapping won't be complete.
+ * caller bits, otherwise the mapping won't be complete.
  */
 #define P4_CONFIG_EVENT_ALIAS_MASK			  \
 	(p4_config_pack_escr(P4_CONFIG_MASK_ESCR)	| \
arch/x86/kernel/cpu/perf_event_p4.c +30 -36

114 lines not on this page · raw message