tuner_xc2028: Allow selection of the frequency adjustment code for XC3028
PATCH v3 1/1 tuner_xc2028: Allow selection of the frequency adjustment code for XC3028
Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work anymore, and nobody feels responsible to fix it.
The code to get it work is still in there, it's only commented out. My patch to enable it was rejected, because somebody had fear that it could break other cards.
So here is a new patch, that allows you to select the frequency adjustment code by a module parameter. Default is the old code, so it can't break anything.
---
drivers/media/common/tuners/tuner-xc2028.c +30 -23
@@ -54,6 +54,11 @@MODULE_PARM_DESC (firmware_name,"Firmware file name. Allows overriding the " "default firmware name\n" ); +static int freq_magic; +module_param (freq_magic, int,0644 ); +MODULE_PARM_DESC (freq_magic,"Selects the frequency adjustment code " +"for XC3028. Set it to 1 if tuning fails." ); +static LIST_HEAD (hybrid_tuner_instance_list);static DEFINE_MUTEX (xc2028_list_mutex);
@@ -967,34 +972,36 @@* newer firmwares */ -#if 1 -/* -* The proper adjustment would be to do it at s-code table. -* However, this didn't work, as reported by -* Robert Lowery <[email protected]> -*/ - -if (priv->cur_fw.type &DTV7 ) - offset +=500000 ; - -#else -/* -* Still need tests for XC3028L (firmware 3.2 or upper) -* So, for now, let's just comment the per-firmware -* version of this change. Reports with xc3028l working -* with and without the lines bellow are welcome -*/ +if (!freq_magic) { +/* +* The proper adjustment would be to do it at s-code +* table. However, this didn't work, as reported by +* Robert Lowery <[email protected]> +*/ -if (priv->firm_version <0x0302 ) {if (priv->cur_fw.type &DTV7 ) offset +=500000 ; + }else { -if (priv->cur_fw.type &DTV7 ) - offset -=300000 ; -else if (type !=ATSC )/* DVB @6MHz, DTV 8 and DTV 7/8 */ - offset +=200000 ; +/* +* Still need tests for XC3028L (firmware 3.2 or upper) +* So, for now, let's just comment the per-firmware +* version of this change. Reports with xc3028l working +* with and without the lines bellow are welcome +*/ + +if (priv->firm_version <0x0302 ) { +if (priv->cur_fw.type &DTV7 ) + offset +=500000 ; + }else { +if (priv->cur_fw.type &DTV7 ) + offset -=300000 ; +else if (type !=ATSC ) { +/* DVB @6MHz, DTV 8 and DTV 7/8 */ + offset +=200000 ; + } + } } -#endif } div = (freq - offset +DIV /2 ) /DIV ;
Hi Alina,
Em 22-07-2011 15:35, Alina Friedrichsen escreveu:
Quoted 2 lines
Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work anymore, and nobody feels responsible to fix it.
No. The problem is that fixing it would require someone to travel around the globe with several different boards, in order to see how the driver works on each Country (or having a DTV generator capable of simulating the Country differences on a reliable way). In particular, Australia requires a different setting than Europe. The code tries to figure out that, but I'm starting to suspect that with a few demods, such adjustments are different.
Btw, what's the video standard that you're using? DTV7? Does your device use a xc3028 or xc3028xl? Whats's your demod and board?
Quoted 13 lines
The code to get it work is still in there, it's only commented out. My patch to enable it was rejected, because somebody had fear that it could break other cards.
So here is a new patch, that allows you to select the frequency adjustment code by a module parameter. Default is the old code, so it can't break anything.Signed-off-by Alina Friedrichsen <[email protected]>---
diff -urNlinux-3.0.orig/drivers/media/common/tuners/tuner-xc2028.clinux-3.0/drivers/media/common/tuners/tuner-xc2028.c
drivers/media/common/tuners/tuner-xc2028.c line 60
Quoted 7 lines
drivers/media/common/tuners/tuner-xc2028.c +4
-0@@ -54,6 +54,11 @@MODULE_PARM_DESC (firmware_name,"Firmware file name. Allows overriding the " "default firmware name\n" ); +static int freq_magic; +module_param (freq_magic, int,0644 ); +MODULE_PARM_DESC (freq_magic,"Selects the frequency adjustment code " +"for XC3028. Set it to 1 if tuning fails." );
While I really prefer to fix the code, I might accept a hack like that, if better named, and properly described. It is more like an alternate way to set the tuner, and for sure it won't solve all cases where the tuning fails.
AFAIK, the driver only has problem with DTV7. So, the hack should not be applied for other standards.
Quoted 69 lines
drivers/media/common/tuners/tuner-xc2028.c +26
-24+static LIST_HEAD (hybrid_tuner_instance_list);static DEFINE_MUTEX (xc2028_list_mutex);@@ -967,34 +972,36 @@* newer firmwares */ -#if 1 -/* -* The proper adjustment would be to do it at s-code table. -* However, this didn't work, as reported by -* Robert Lowery <[email protected]> -*/ - -if (priv->cur_fw.type &DTV7 ) - offset +=500000 ; - -#else -/* -* Still need tests for XC3028L (firmware 3.2 or upper) -* So, for now, let's just comment the per-firmware -* version of this change. Reports with xc3028l working -* with and without the lines bellow are welcome -*/ +if (!freq_magic) { +/* +* The proper adjustment would be to do it at s-code +* table. However, this didn't work, as reported by +* Robert Lowery <[email protected]> +*/ -if (priv->firm_version <0x0302 ) {if (priv->cur_fw.type &DTV7 ) offset +=500000 ; + }else { -if (priv->cur_fw.type &DTV7 ) - offset -=300000 ; -else if (type !=ATSC )/* DVB @6MHz, DTV 8 and DTV 7/8 */ - offset +=200000 ; +/* +* Still need tests for XC3028L (firmware 3.2 or upper) +* So, for now, let's just comment the per-firmware +* version of this change. Reports with xc3028l working +* with and without the lines bellow are welcome +*/ + +if (priv->firm_version <0x0302 ) { +if (priv->cur_fw.type &DTV7 ) + offset +=500000 ; + }else { +if (priv->cur_fw.type &DTV7 ) + offset -=300000 ; +else if (type !=ATSC ) { +/* DVB @6MHz, DTV 8 and DTV 7/8 */ + offset +=200000 ; + } + } } -#endif } div = (freq - offset +DIV /2 ) /DIV ; --To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 2 lines · Mauro Carvalho Chehab
Btw, what's the video standard that you're using? DTV7? Does your device use a xc3028 or xc3028xl? Whats's your demod and board?
It was in the first sentence of his email. He's got an HVR-1400, which uses the xc3028L and dib7000p.
It's also worth noting that he isn't the first person to complain about tuning offset problems with the xc3028L. Just look at the rather nasty hack some random user did for the EVGA inDtube (which is xc3208L/s5h1409).
http://linuxtv.org/wiki/index.php/EVGA_inDtube
Bear in mind that it worked when I added the original support. Somebody caused a regression since then though.
In short, I can appreciate why the user is frustrated. The xc3028L support worked at one point and then somebody broke the xc3028 driver.
Devin
Signature · 2 lines
Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com
Em 27-07-2011 11:58, Devin Heitmueller escreveu:
Quoted 7 lines
Quoted 2 lines · Mauro Carvalho Chehab
Btw, what's the video standard that you're using? DTV7? Does your device use a xc3028 or xc3028xl? Whats's your demod and board?
It was in the first sentence of his email. He's got an HVR-1400, which uses the xc3028L and dib7000p.
Hmm...
case CX23885_BOARD_HAUPPAUGE_HVR1400:
i2c_bus = &dev->i2c_bus[0];
fe0->dvb.frontend = dvb_attach(dib7000p_attach,
&i2c_bus->i2c_adap,
0x12, &hauppauge_hvr1400_dib7000_config);
if (fe0->dvb.frontend != NULL) {
struct dvb_frontend *fe;
struct xc2028_config cfg = {
.i2c_adap = &dev->i2c_bus[1].i2c_adap,
.i2c_addr = 0x64,
};
static struct xc2028_ctrl ctl = {
.fname = XC3028L_DEFAULT_FIRMWARE,
.max_len = 64,
.demod = 5000,
/* This is true for all demods with
v36 firmware? */
.type = XC2028_D2633,
};The entry for xc2028 there seems to be wrong! it is specifying a magic value for .demod, instead of using one of the defined values for it.
On a quick look, this seems to be the only case where the macro is not used:
$ grep -E "demod\s+\=" `find drivers/media/ -type f` drivers/media/video/cx231xx/cx231xx-cards.c: .demod = 0; drivers/media/video/cx23885/cx23885-dvb.c: .demod = XC3028_FE_OREN538, drivers/media/video/cx23885/cx23885-dvb.c: .demod = 5000, drivers/media/video/cx23885/cx23885-dvb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/video/cx23885/cx23885-dvb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/video/cx88/cx88-cards.c: ctl->demod = XC3028_FE_ZARLINK456; drivers/media/video/cx88/cx88-cards.c: ctl->demod = XC3028_FE_OREN538; drivers/media/video/cx88/cx88-cards.c: ctl->demod = XC3028_FE_ZARLINK456; drivers/media/video/cx88/cx88-cards.c: ctl->demod = XC3028_FE_OREN538; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_ZARLINK456; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_ZARLINK456; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_DEFAULT; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_DEFAULT; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_DEFAULT; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_CHINA; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_CHINA; drivers/media/video/em28xx/em28xx-cards.c: ctl->demod = XC3028_FE_OREN538; drivers/media/video/cx18/cx18-dvb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/video/cx18/cx18-dvb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/video/cx18/cx18-dvb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/video/saa7134/saa7134-cards.c: ctl.demod = XC3028_FE_ZARLINK456; drivers/media/video/saa7134/saa7134-cards.c: ctl.demod = XC3028_FE_OREN538; drivers/media/dvb/dvb-usb/cxusb.c: .demod = XC3028_FE_ZARLINK456, drivers/media/dvb/dvb-usb/dib0700_devices.c: .demod = XC3028_FE_DIBCOM52, (non-relevant results removed)
In the specific case of this device, it should be using this macro:
#define XC3028_FE_DIBCOM52 5200
As it uses a Dibcom firmware. The logic inside tuner-xc2028 assumes that those macros are used.
Quoted 4 lines
It's also worth noting that he isn't the first person to complain about tuning offset problems with the xc3028L. Just look at the rather nasty hack some random user did for the EVGA inDtube (which is xc3208L/s5h1409).
As some drivers are properly using the macros while others aren't that explains why when someone fixes xc3028 for a device, it breaks support for other devices.
We should make sure that all devices will use the proper macros, and then look into a fix for the logic.
Quoted 11 lines
http://linuxtv.org/wiki/index.php/EVGA_inDtube
Bear in mind that it worked when I added the original support. Somebody caused a regression since then though.
In short, I can appreciate why the user is frustrated. The xc3028L support worked at one point and then somebody broke the xc3028 driver.
Devin
Em 27-07-2011 11:58, Devin Heitmueller escreveu:
Quoted 15 lines
Quoted 2 lines · Mauro Carvalho Chehab
Btw, what's the video standard that you're using? DTV7? Does your device use a xc3028 or xc3028xl? Whats's your demod and board?
It was in the first sentence of his email. He's got an HVR-1400, which uses the xc3028L and dib7000p.
It's also worth noting that he isn't the first person to complain about tuning offset problems with the xc3028L. Just look at the rather nasty hack some random user did for the EVGA inDtube (which is xc3208L/s5h1409).
Quoted 8 lines
Bear in mind that it worked when I added the original support. Somebody caused a regression since then though.
In short, I can appreciate why the user is frustrated. The xc3028L support worked at one point and then somebody broke the xc3028 driver.
Devin
Btw, looking at the firmware for xc3028L [1], with the v4l-utils /utils/xc3028-firmware/firmware-tool:
[1] http://steventoth.net/linux/hvr1400/xc3028L-v36.fw
firmware file name: /lib/firmware/xc3028L-v36.fw
firmware name: xc2028 firmware
version: 3.6 (774)
standards: 81
Firmware 0, type: BASE FW F8MHZ (0x00000003), id: (0000000000000000), size: 9144 Firmware 1, type: BASE FW F8MHZ MTS (0x00000007), id: (0000000000000000), size: 9030 Firmware 2, type: BASE FW FM (0x00000401), id: (0000000000000000), size: 9054 Firmware 3, type: BASE FW FM INPUT1 (0x00000c01), id: (0000000000000000), size: 9068 Firmware 4, type: BASE FW (0x00000001), id: (0000000000000000), size: 9132 Firmware 5, type: BASE FW MTS (0x00000005), id: (0000000000000000), size: 9006 Firmware 6, type: STD FW (0x00000000), id: PAL/BG (0000000000000007), size: 161 Firmware 7, type: STD FW MTS (0x00000004), id: PAL/BG (0000000000000007), size: 169 Firmware 8, type: STD FW (0x00000000), id: PAL/BG (0000000000000007), size: 161 Firmware 9, type: STD FW MTS (0x00000004), id: PAL/BG (0000000000000007), size: 169 Firmware 10, type: STD FW (0x00000000), id: PAL/BG (0000000000000007), size: 161 Firmware 11, type: STD FW MTS (0x00000004), id: PAL/BG (0000000000000007), size: 169 Firmware 12, type: STD FW (0x00000000), id: PAL/BG (0000000000000007), size: 161 Firmware 13, type: STD FW MTS (0x00000004), id: PAL/BG (0000000000000007), size: 169 Firmware 14, type: STD FW (0x00000000), id: PAL/DK (00000000000000e0), size: 161 Firmware 15, type: STD FW MTS (0x00000004), id: PAL/DK (00000000000000e0), size: 169 Firmware 16, type: STD FW (0x00000000), id: PAL/DK (00000000000000e0), size: 161 Firmware 17, type: STD FW MTS (0x00000004), id: PAL/DK (00000000000000e0), size: 169 Firmware 18, type: STD FW (0x00000000), id: SECAM/K1 (0000000000200000), size: 161 Firmware 19, type: STD FW MTS (0x00000004), id: SECAM/K1 (0000000000200000), size: 169 Firmware 20, type: STD FW (0x00000000), id: SECAM/K3 (0000000004000000), size: 161 Firmware 21, type: STD FW MTS (0x00000004), id: SECAM/K3 (0000000004000000), size: 169 Firmware 22, type: STD FW D2633 DTV6 ATSC (0x00010030), id: (0000000000000000), size: 149 Firmware 23, type: STD FW D2620 DTV6 QAM (0x00000068), id: (0000000000000000), size: 149 Firmware 24, type: STD FW D2633 DTV6 QAM (0x00000070), id: (0000000000000000), size: 149 Firmware 25, type: STD FW D2620 DTV7 (0x00000088), id: (0000000000000000), size: 149 Firmware 26, type: STD FW D2633 DTV7 (0x00000090), id: (0000000000000000), size: 149 Firmware 27, type: STD FW D2620 DTV78 (0x00000108), id: (0000000000000000), size: 149 Firmware 28, type: STD FW D2633 DTV78 (0x00000110), id: (0000000000000000), size: 149 Firmware 29, type: STD FW D2620 DTV8 (0x00000208), id: (0000000000000000), size: 149 Firmware 30, type: STD FW D2633 DTV8 (0x00000210), id: (0000000000000000), size: 149 Firmware 31, type: STD FW FM (0x00000400), id: (0000000000000000), size: 135 Firmware 32, type: STD FW (0x00000000), id: PAL/I (0000000000000010), size: 161 Firmware 33, type: STD FW MTS (0x00000004), id: PAL/I (0000000000000010), size: 169 Firmware 34, type: STD FW (0x00000000), id: SECAM/L (0000000000400000), size: 161 Firmware 35, type: STD FW (0x00000000), id: SECAM/Lc (0000000000800000), size: 161 Firmware 36, type: STD FW (0x00000000), id: NTSC/M Kr (0000000000008000), size: 161 Firmware 37, type: STD FW LCD (0x00001000), id: NTSC/M Kr (0000000000008000), size: 161 Firmware 38, type: STD FW LCD NOGD (0x00003000), id: NTSC/M Kr (0000000000008000), size: 161 Firmware 39, type: STD FW MTS (0x00000004), id: NTSC/M Kr (0000000000008000), size: 169 Firmware 40, type: STD FW (0x00000000), id: NTSC PAL/M PAL/N (000000000000b700), size: 161 Firmware 41, type: STD FW LCD (0x00001000), id: NTSC PAL/M PAL/N (000000000000b700), size: 161 Firmware 42, type: STD FW LCD NOGD (0x00003000), id: NTSC PAL/M PAL/N (000000000000b700), size: 161 Firmware 43, type: STD FW (0x00000000), id: NTSC/M Jp (0000000000002000), size: 161 Firmware 44, type: STD FW MTS (0x00000004), id: NTSC PAL/M PAL/N (000000000000b700), size: 169 Firmware 45, type: STD FW MTS LCD (0x00001004), id: NTSC PAL/M PAL/N (000000000000b700), size: 169 Firmware 46, type: STD FW MTS LCD NOGD (0x00003004), id: NTSC PAL/M PAL/N (000000000000b700), size: 169 Firmware 47, type: SCODE FW HAS IF (0x60000000), IF = 3.28 MHz id: (0000000000000000), size: 192 Firmware 48, type: SCODE FW HAS IF (0x60000000), IF = 3.30 MHz id: (0000000000000000), size: 192 Firmware 49, type: SCODE FW HAS IF (0x60000000), IF = 3.44 MHz id: (0000000000000000), size: 192 Firmware 50, type: SCODE FW HAS IF (0x60000000), IF = 3.46 MHz id: (0000000000000000), size: 192 Firmware 51, type: SCODE FW DTV6 ATSC OREN36 HAS IF (0x60210020), IF = 3.80 MHz id: (0000000000000000), size: 192 Firmware 52, type: SCODE FW HAS IF (0x60000000), IF = 4.00 MHz id: (0000000000000000), size: 192 Firmware 53, type: SCODE FW DTV6 ATSC TOYOTA388 HAS IF (0x60410020), IF = 4.08 MHz id: (0000000000000000), size: 192 Firmware 54, type: SCODE FW HAS IF (0x60000000), IF = 4.20 MHz id: (0000000000000000), size: 192 Firmware 55, type: SCODE FW MONO HAS IF (0x60008000), IF = 4.32 MHz id: NTSC/M Kr (0000000000008000), size: 192 Firmware 56, type: SCODE FW HAS IF (0x60000000), IF = 4.45 MHz id: (0000000000000000), size: 192 Firmware 57, type: SCODE FW MTS LCD NOGD MONO IF HAS IF (0x6002b004), IF = 4.50 MHz id: NTSC PAL/M PAL/N (000000000000b700), size: 192 Firmware 58, type: SCODE FW DTV78 DTV8 ZARLINK456 HAS IF (0x62000300), IF = 4.56 MHz id: (0000000000000000), size: 192 Firmware 59, type: SCODE FW LCD NOGD IF HAS IF (0x60023000), IF = 4.60 MHz id: NTSC/M Kr (0000000000008000), size: 192 Firmware 60, type: SCODE FW DTV6 QAM DTV7 ZARLINK456 HAS IF (0x620000e0), IF = 4.76 MHz id: (0000000000000000), size: 192 Firmware 61, type: SCODE FW HAS IF (0x60000000), IF = 4.94 MHz id: (0000000000000000), size: 192 Firmware 62, type: SCODE FW DTV78 DTV8 DIBCOM52 HAS IF (0x61000300), IF = 5.20 MHz id: (0000000000000000), size: 192 Firmware 63, type: SCODE FW HAS IF (0x60000000), IF = 5.26 MHz id: (0000000000000000), size: 192 Firmware 64, type: SCODE FW MONO HAS IF (0x60008000), IF = 5.32 MHz id: PAL/BG (0000000000000007), size: 192 Firmware 65, type: SCODE FW DTV7 DTV8 DIBCOM52 CHINA HAS IF (0x65000280), IF = 5.40 MHz id: (0000000000000000), size: 192 Firmware 66, type: SCODE FW DTV6 ATSC OREN538 HAS IF (0x60110020), IF = 5.58 MHz id: (0000000000000000), size: 192 Firmware 67, type: SCODE FW HAS IF (0x60000000), IF = 5.64 MHz id: PAL/BG (0000000000000007), size: 192 Firmware 68, type: SCODE FW HAS IF (0x60000000), IF = 5.74 MHz id: PAL/BG (0000000000000007), size: 192 Firmware 69, type: SCODE FW HAS IF (0x60000000), IF = 5.90 MHz id: (0000000000000000), size: 192 Firmware 70, type: SCODE FW MONO HAS IF (0x60008000), IF = 6.00 MHz id: PAL/DK PAL/I SECAM/K3 SECAM/L SECAM/Lc (0000000004c000f0), size: 192 Firmware 71, type: SCODE FW DTV6 QAM ATSC LG60 F6MHZ HAS IF (0x68050060), IF = 6.20 MHz id: (0000000000000000), size: 192 Firmware 72, type: SCODE FW HAS IF (0x60000000), IF = 6.24 MHz id: PAL/I (0000000000000010), size: 192 Firmware 73, type: SCODE FW MONO HAS IF (0x60008000), IF = 6.32 MHz id: SECAM/K1 (0000000000200000), size: 192 Firmware 74, type: SCODE FW HAS IF (0x60000000), IF = 6.34 MHz id: SECAM/K1 (0000000000200000), size: 192 Firmware 75, type: SCODE FW MONO HAS IF (0x60008000), IF = 6.50 MHz id: PAL/DK SECAM/K3 (00000000040000e0), size: 192 Firmware 76, type: SCODE FW DTV6 ATSC ATI638 HAS IF (0x60090020), IF = 6.58 MHz id: (0000000000000000), size: 192 Firmware 77, type: SCODE FW HAS IF (0x60000000), IF = 6.60 MHz id: PAL/DK (00000000000000e0), size: 192 Firmware 78, type: SCODE FW MONO HAS IF (0x60008000), IF = 6.68 MHz id: PAL/DK (00000000000000e0), size: 192 Firmware 79, type: SCODE FW DTV6 ATSC TOYOTA794 HAS IF (0x60810020), IF = 8.14 MHz id: (0000000000000000), size: 192 Firmware 80, type: SCODE FW HAS IF (0x60000000), IF = 8.20 MHz id: (0000000000000000), size: 192
It seems that the firmware file was not properly generated, as it is pointing two firmwares with DIBCOM52 and two firmwares with ZARLINK456, one with 200 kHz of offset for the other.
This is not a big issue, as the driver won't use this information anymore, but that means that maybe there's something wrong at the scode tables.
In any case, there's no firmware associated with IF = 5 MHz, so, if the driver logic is ok, it won't be loading any SCODE table for the device.
Cheers,
Mauro
Alina,
Em 22-07-2011 15:35, Alina Friedrichsen escreveu:
Quoted 2 lines
Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work anymore, and nobody feels responsible to fix it.
Could you please check if the enclosed patch fixes the tuner issue?
Use it instead of the patch you've made. If it doesn't work, please send us the dmesg logs with tuner-xc2028 debug enabled.
Thanks!
Mauro
-
cx23885-dvb: Fix demod IF
This device is not using the proper demod IF. Instead of using the IF macro, it is specifying a IF frequency. This doesn't work, as xc3028 needs to load an specific SCODE for the tuner. In this case, there's no IF table for 5 MHz.
drivers/media/video/cx23885/cx23885-dvb.c +1 -1
@@ -844,7 +844,7 @@ static int dvb_register(struct cx23885_tsport *port)static struct xc2028_ctrl ctl = { .fname =XC3028L_DEFAULT_FIRMWARE , .max_len =64 , - .demod =5000 , + .demod =XC3028_FE_DIBCOM52 ,/* This is true for all demods with v36 firmware? */ .type =XC2028_D2633 ,
Hi Mauro and Devin,
first I'm a she.
Quoted 5 lines
Could you please check if the enclosed patch fixes the tuner issue?
Use it instead of the patch you've made. If it doesn't work, please send us
the dmesg logs with tuner-xc2028 debug enabled.
Great, it works! :)
Much, much thanks.
Please let this patch upstream as fast as possible.
Regards,
Alina