block: use the logical OR condition at blk_flush_complete_seq

PATCH New Kyungmin Park 1 participant 1 message Jul 25, 2011 Block layer

lore

Share & tools

lore

Kyungmin Park

author

2011-07-25 11:03 UTC #0 lore raw

PATCH 1/1 block: use the logical OR condition at blk_flush_complete_seq

From: Kyungmin Park <[email protected]>

Even though the meaning is same, use the logical OR condition instead ORing.

seq blk_kick_flush(q) queued
1 1 0 => true
2 0 1 => true
8 0 0 => false

Signed-off-by Kyungmin Park <[email protected]>

---

block/blk-flush.c +1 -1

index bb21e4c..66e0acb 100644
@@ -187,7 +187,7 @@ static bool blk_flush_complete_seq(struct request *rq, unsigned int seq,
 		BUG();
 	}
 
-	return blk_kick_flush(q) | queued;
+	return blk_kick_flush(q) || queued;
 }
 
 static void flush_end_io(struct request *flush_rq, int error)