x86: Add reboot quirk for Dell Precision M4600
PATCH 1/1 x86: Add reboot quirk for Dell Precision M4600
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
arch/x86/kernel/reboot.c +9 -0
@@ -443,6 +443,15 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6420"), }, }, + { /* Handle problems with rebooting on Dell Precision M4600's */ + .callback = set_pci_reboot, + .ident = "Dell Precision M4600", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Precision M4600"), + }, + }, + { } };
Quoted 8 lines · Mel Gorman
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
Reported-and-tested-by Bruno Friedmann <[email protected]>Signed-off-by Mel Gorman <[email protected]>--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Thanks,
Ingo
H. Peter Anvin
reviewerQuoted 12 lines · Ingo Molnar
Quoted 8 lines · Mel Gorman
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
Reported-and-tested-by Bruno Friedmann <[email protected]>Signed-off-by Mel Gorman <[email protected]>--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
Quoted 8 lines
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Thanks,
Ingo
It seems almost all the affected machines are Dell, too... very odd, no?
Signature · 1 line
Sent from my mobile phone. Please excuse my brevity and lack of formatting.
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
Signature · 1 line
Matthew Garrett | [email protected]
Len Brown
reviewerQuoted 13 lines · H. Peter Anvin
Quoted 11 lines · Ingo Molnar
Quoted 8 lines · Mel Gorman
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
Reported-and-tested-by Bruno Friedmann <[email protected]>Signed-off-by Mel Gorman <[email protected]>--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
Quoted 6 lines
Quoted 4 lines
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
It seems almost all the affected machines are Dell, too... very odd, no?
Dell website says that the M4600 is current, and ships with Windows 7. It is a "mobile workstation", so it is more likely to have a windows "feature" driver, say, than Dell's servers.
Matthew,
Did you do your reboot comopatibility test using Win7, or something older?
BTW, it would be nice if ACPI incompatibilities and workarounds somehow got stuck in the ACPI code rather than the arch code. Unfortunately this kind sets a working reboot method instead of disabling a non-working one -- so what it overrides has changed when the default changed.
thanks,
-Len Brown, Intel Open Source Technolgy Center
Quoted 20 lines · Len Brown
Quoted 18 lines · H. Peter Anvin
Quoted 15 lines · Ingo Molnar
Quoted 8 lines · Mel Gorman
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
Reported-and-tested-by Bruno Friedmann <[email protected]>Signed-off-by Mel Gorman <[email protected]>--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
Quoted 1 line
It seems almost all the affected machines are Dell, too... very odd, no?
Dell website says that the M4600 is current, and ships with Windows 7. It is a "mobile workstation", so it is more likely to have a windows "feature" driver, say, than Dell's servers.
And this computer can be buyed with RedHat 6.0 by phone call.
If you check the support website download and drivers you will some drivers for Redhat (mainly the new version of alsa)
http://dell.to/r1IKhp
Quoted 5 lines
Matthew,
Did you do your reboot comopatibility test using Win7, or something older?
Quoted 9 lines
BTW, it would be nice if ACPI incompatibilities and workarounds somehow got stuck in the ACPI code rather than the arch code. Unfortunately this kind sets a working reboot method instead of disabling a non-working one -- so what it overrides has changed when the default changed.
thanks,
-Len Brown, Intel Open Source Technolgy Center
In any case, if you want anymore testing, and dumps of something, just drop me an email and the howto get it formatted as you want it.
Actually I'm in the desktop summit with the computer until 9th August night.
I don't know if we can find an owner of the M6600 (the 17") version to get feedback about that hardware which share a lot with the M4600.
Also Dell can upgrade their Bios.
The only error or significant warning I saw in boot.msg is
<3>[ 36.851649] sdhci-pci 0000:0b:00.1: Invalid iomem size. You may experience problems.
Signature · 10 lines
Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Ambassador GPG KEY : D5C9B751C4653227 irc: tigerfoot -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 12 lines · Ingo Molnar
Quoted 8 lines · Mel Gorman
ACPI reboot does not work for Dell Precision M4600. Detect this machine via DMI and force the use of the PCI reboot method.
Reported-and-tested-by Bruno Friedmann <[email protected]>Signed-off-by Mel Gorman <[email protected]>--- arch/x86/kernel/reboot.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
Quoted 5 lines
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
I have no idea and am not well versed on how this sort of problem is normally investigated.
As Matthew is the person most likely to be able to fix this, I'll defer to him. Matthew, would you prefer a quirk be added or hold off until there is time to investigate an alternative?
Signature · 2 lines
Mel Gorman SUSE Labs
H. Peter Anvin
reviewerQuoted 6 lines · Matthew Garrett
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
I have a vague suspicion that Windows might have a meta-quirk for this class of machines, i.e. if the ACPI reboot method, say, points at the keyboard controller or points at the "PCI" reboot port then it actually uses its own special-purpose routines rather than general routines. It would be extremely interesting to know if "reboot=kbd" works on these boxen.
-hpa
Quoted 14 lines · H. Peter Anvin
Quoted 6 lines · Matthew Garrett
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
Quoted 8 lines
I have a vague suspicion that Windows might have a meta-quirk for this class of machines, i.e. if the ACPI reboot method, say, points at the keyboard controller or points at the "PCI" reboot port then it actually uses its own special-purpose routines rather than general routines. It would be extremely interesting to know if "reboot=kbd" works on these boxen.
-hpa
Ok I will try to activate reboot=kbd tomorrow morning and report the result about it.
Signature · 6 lines
Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Ambassador GPG KEY : D5C9B751C4653227 irc: tigerfoot
Quoted 14 lines · H. Peter Anvin
Quoted 6 lines · Matthew Garrett
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
Quoted 8 lines
I have a vague suspicion that Windows might have a meta-quirk for this class of machines, i.e. if the ACPI reboot method, say, points at the keyboard controller or points at the "PCI" reboot port then it actually uses its own special-purpose routines rather than general routines. It would be extremely interesting to know if "reboot=kbd" works on these boxen.
-hpa
Test done with reboot=pci and unfortunately doesn't work.
Signature · 6 lines
Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Ambassador GPG KEY : D5C9B751C4653227 irc: tigerfoot
Quoted 21 lines · Bruno Friedmann
Quoted 20 lines · H. Peter Anvin
Quoted 6 lines · Matthew Garrett
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
I have a vague suspicion that Windows might have a meta-quirk for this class of machines, i.e. if the ACPI reboot method, say, points at the keyboard controller or points at the "PCI" reboot port then it actually uses its own special-purpose routines rather than general routines. It would be extremely interesting to know if "reboot=kbd" works on these boxen.
Quoted 4 lines
Quoted 2 lines
-hpa
Test done with reboot=pci and unfortunately doesn't work.
Didn't hpa suggest reboot=kbd?
Thanks,
Ingo
Quoted 27 lines · Ingo Molnar
Quoted 24 lines · Bruno Friedmann
Quoted 22 lines · H. Peter Anvin
Quoted 6 lines · Matthew Garrett
Quoted 4 lines · Ingo Molnar
Weird - ACPI is the default Windows method of reboot - how come it does not work on that box? Does Windows work around this specific machine (unlikely), or is our ACPI boot sequence not 100% compatible with the Windows method (more likely IMO)?
Quoted 6 lines
The ACPI reboot method on these machines hits the keyboard controller rather than PCI, which is unusual. What I suspect is that the write triggers some SMM or EC code that's making assumptions about system state, and we're not quite identical. Bouncing on the keyboard controller from userspace with init=/bin/bash wedges in the same way.
I have a vague suspicion that Windows might have a meta-quirk for this class of machines, i.e. if the ACPI reboot method, say, points at the keyboard controller or points at the "PCI" reboot port then it actually uses its own special-purpose routines rather than general routines. It would be extremely interesting to know if "reboot=kbd" works on these boxen.
-hpa
Quoted 7 lines
Quoted 1 line
Test done with reboot=pci and unfortunately doesn't work.
Didn't hpa suggest reboot=kbd?
Thanks,
Ingo
Ingo yeap and reboot=kbd doesn't work ...
I must really be awake before writing
Once the system has synchronised the harddrive, it just stay at now rebooting ...
Signature · 6 lines
Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Ambassador GPG KEY : D5C9B751C4653227 irc: tigerfoot