Skip to contentSkip to conversation

cryptsetup: "FATAL" padlock_{aes,sha} error during boot

PATCH In review Ralf Jung 4 participants 5 messages Jul 28, 2011 – Aug 3, 2011 Crypto API

lore
Share & tools
lore

Ralf Jung

author
#0 lore raw

Hi,

as per request of Jonathan at http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=485070, I am reporting the mentioned bug to this list as well:

With current Debian testing (Kernel 2.6.39), I am getting this error on each boot:
FATAL: Error inserting padlock_sha (/lib/modules/2.6.39-2- amd64/kernel/drivers/crypto/padlock-sha.ko): No such device
I understand it is harmless, but it should still be fixed since it irritates users suggesting something is seriously going wrong.

No patch though, sorry, compiling and botting a custom kernel still sounds like black magic for me ;-)

Kind regards,
Ralf

maintainer
#1 lore raw
Quoted 6 lines · Ralf Jung

Hi,

as per request of Jonathan at http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=485070, I am reporting the mentioned bug to this list as well:

Quoted 6 lines

With current Debian testing (Kernel 2.6.39), I am getting this error on each boot:
FATAL: Error inserting padlock_sha (/lib/modules/2.6.39-2- amd64/kernel/drivers/crypto/padlock-sha.ko): No such device
I understand it is harmless, but it should still be fixed since it irritates users suggesting something is seriously going wrong.

That message comes from user-space and needs to be fixed there.

Cheers,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw

Re: Bug#485070: cryptsetup: "FATAL" padlock_{aes,sha} error during boot

Version: 3.7-pre2-1

Quoted 7 lines · Herbert Xu
Quoted 6 lines · Ralf Jung

Hi,

as per request of Jonathan at http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=485070, I am reporting the mentioned bug to this list as well:

Quoted 8 lines
Quoted 6 lines

With current Debian testing (Kernel 2.6.39), I am getting this error on each boot:
FATAL: Error inserting padlock_sha (/lib/modules/2.6.39-2- amd64/kernel/drivers/crypto/padlock-sha.ko): No such device
I understand it is harmless, but it should still be fixed since it irritates users suggesting something is seriously going wrong.

That message comes from user-space and needs to be fixed there.

Right, it comes from modprobe.

Fixed in module-init-tools version 3.5, commit cdafffbadc5831ad56fe00ecd420ca9c36e9474f ("don't warn noisely if loading multiple module aliases").

Ben.

#3 lore raw

PATCH 1/1 crypto: padlock-aes - Make module loading even quieter when hardware is missing

In reply to Herbert Xu

When loading aes via the module alias, a padlock module failing to load due to missing hardware is not particularly notable. With v2.6.27-rc1~1107^2~14 (crypto: padlock - Make module loading quieter when hardware isn't available, 2008-07-03), the padlock-aes module suppresses the relevant messages when the "quiet" flag is in use; but better to suppress this particular message completely, since the administrator can already distinguish such errors by the absence of a message indicating initialization failing or succeeding.

This avoids occasional messages in syslog of the form

padlock_aes: VIA PadLock not detected.

---

Quoted 6 lines · Herbert Xu
Quoted 4 lines · Ralf Jung

With current Debian testing (Kernel 2.6.39), I am getting this error on each boot:
FATAL: Error inserting padlock_sha (/lib/modules/2.6.39-2- amd64/kernel/drivers/crypto/padlock-sha.ko): No such device

[...]

Quoted 1 line

That message comes from user-space and needs to be fixed there.

Thanks. Indeed, I was sloppy when reading the original report and thought he was talking about a different message. Sorry for the noise.

 drivers/crypto/padlock-aes.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/crypto/padlock-aes.c +1 -3
index db33d300..29b9469f 100644
@@ -508,10 +508,8 @@ static int __init padlock_init(void)
 	int ret;
 	struct cpuinfo_x86 *c = &cpu_data(0);
 
-	if (!cpu_has_xcrypt) {
-		printk(KERN_NOTICE PFX "VIA PadLock not detected.\n");
+	if (!cpu_has_xcrypt)
 		return -ENODEV;
-	}
 
 	if (!cpu_has_xcrypt_enabled) {
 		printk(KERN_NOTICE PFX "VIA PadLock detected, but not enabled. Hmm, strange...\n");
Signature · 1 line
1.7.6
maintainer
#4 lore raw

Re: [PATCH] crypto: padlock-aes - Make module loading even quieter when hardware is missing

Quoted 9 lines · Jonathan Nieder

When loading aes via the module alias, a padlock module failing to load due to missing hardware is not particularly notable. With v2.6.27-rc1~1107^2~14 (crypto: padlock - Make module loading quieter when hardware isn't available, 2008-07-03), the padlock-aes module suppresses the relevant messages when the "quiet" flag is in use; but better to suppress this particular message completely, since the administrator can already distinguish such errors by the absence of a message indicating initialization failing or succeeding.

Quoted 5 lines

This avoids occasional messages in syslog of the form

padlock_aes: VIA PadLock not detected.

Patch applied. Thanks Jonathan!

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt