rtl8712: don't just return -EFAULT in wpa_supplicant_ioctl()

PATCH New Dan Carpenter 1 participant 1 message Aug 6, 2011

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2011-08-06 14:27 UTC #0 lore raw

PATCH 1/1 rtl8712: don't just return -EFAULT in wpa_supplicant_ioctl()

There were some curly braces missing so the original code in wpa_supplicant_ioctl() pretty much always returned -EFAULT without doing anything.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/rtl8712/rtl871x_ioctl_linux.c +2 -1

index 40e6b5c..c380a30 100644
@@ -2072,9 +2072,10 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p)
 	param = (struct ieee_param *)_malloc(p->length);
 	if (param = NULL)
 		return -ENOMEM;
-	if (copy_from_user(param, p->pointer, p->length))
+	if (copy_from_user(param, p->pointer, p->length)) {
 		kfree((u8 *)param);
 		return -EFAULT;
+	}
 	switch (param->cmd) {
 	case IEEE_CMD_SET_WPA_PARAM:
 		ret = wpa_set_param(dev, param->u.wpa_param.name,