Skip to contentSkip to conversation

iscsi-target: remove duplicate return

PATCH In review Dan Carpenter 2 participants 2 messages Aug 6, 2011 – Aug 8, 2011

Subsystems (3)
SCSI Kernel janitors SCSI target
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 iscsi-target: remove duplicate return

We returned on the line before already.

Signed-off-by Dan Carpenter <[email protected]>
drivers/target/iscsi/iscsi_target.c +0 -1
index c24fb10..6a4ea29 100644
@@ -2243,7 +2243,6 @@ static int iscsit_handle_snack(
 	case 0:
 		return iscsit_handle_recovery_datain_or_r2t(conn, buf,
 			hdr->itt, hdr->ttt, hdr->begrun, hdr->runlength);
-		return 0;
 	case ISCSI_FLAG_SNACK_TYPE_STATUS:
 		return iscsit_handle_status_snack(conn, hdr->itt, hdr->ttt,
 			hdr->begrun, hdr->runlength);
#1 lore raw
Quoted 9 lines · Dan Carpenter

We returned on the line before already.

Signed-off-by Dan Carpenter <[email protected]>
drivers/target/iscsi/iscsi_target.c +0 -0
index c24fb10..6a4ea29 100644

drivers/target/iscsi/iscsi_target.c static int iscsit_handle_snack(

Quoted 8 lines
drivers/target/iscsi/iscsi_target.c +0 -2
@@ -2243,7 +2243,6 @@ static int iscsit_handle_snack(
 	case 0:
 		return iscsit_handle_recovery_datain_or_r2t(conn, buf,
 			hdr->itt, hdr->ttt, hdr->begrun, hdr->runlength);
-		return 0;
 	case ISCSI_FLAG_SNACK_TYPE_STATUS:
 		return iscsit_handle_status_snack(conn, hdr->itt, hdr->ttt,
 			hdr->begrun, hdr->runlength);
--

Thanks Dan, committed as 69b0ec3c38

--nab