Skip to contentSkip to conversation

p1010rdb: gianfar config does not have queues.

PATCH In review Robin Holt 3 participants 4 messages Aug 11, 2011 – Mar 21, 2012

Subsystems (2)
Device tree bindings PowerPC
lore
Share & tools
lore

Robin Holt

author
#0 lore raw

PATCH 1/1 p1010rdb: gianfar config does not have queues.

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties defined in the p1010's device tree file, I get a kernel panic very shortly after boot. The failure indicates we are configuring the gianfar.c driver for a queue depth greater than actual. Removing the properties got the problem resolved.

Signed-off-by Robin Holt <[email protected]>

To: U Bhaskar-B22300 <[email protected]>
Cc: PPC list <[email protected]>
Cc: Eric Dumazet <[email protected]>

arch/powerpc/boot/dts/p1010si.dtsi +0 -6
index 7f51104..91566aa 100644
@@ -258,8 +258,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 

@@ -280,8 +278,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 

@@ -302,8 +298,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
#1 lore raw
Quoted 10 lines · Robin Holt

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties defined in the p1010's device tree file, I get a kernel panic very shortly after boot. The failure indicates we are configuring the gianfar.c driver for a queue depth greater than actual. Removing the properties got the problem resolved.
=20

Signed-off-by Robin Holt <[email protected]>

To: U Bhaskar-B22300 <[email protected]>
Cc: PPC list <[email protected]>
Cc: Eric Dumazet <[email protected]>

Poonam,

Can you comment on this patch, does it look correct?

- k

=

Quoted 2 lines

=20

= renamed from arch/powerpc/boot/dts/p1010si.dtsi +0 -0

b/arch/powerpc/boot/dts/p1010si.dtsi

Quoted 34 lines

index 7f51104..91566aa 100644

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
@@ -258,8 +258,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
@@ -280,8 +278,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
@@ -302,8 +298,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

#2 lore raw

Hello Pankaj, Rajan

DO you have any comments on the below patch of gianfar?

Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +0 -2
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;

Have been removed from P1010RDB device tree to avoid a kernel panic.

Kumar, as such I see this is the old dts format. Also in the latest sdk tre= e these properties are defined, not sure it is working on P1010RDB. I can check on this and get back.

Regards
Poonam

Quoted 65 lines

-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, March 16, 2012 8:50 PM
To: Aggrwal Poonam-B10812
Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues. =20
=20
On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
=20

Quoted 10 lines

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties defined in the p1010's device tree file, I get a kernel panic very shortly after boot. The failure indicates we are configuring the gianfar.c driver for a queue depth greater than actual. Removing the properties got the problem resolved.

Signed-off-by Robin Holt <[email protected]>

To: U Bhaskar-B22300 <[email protected]>
Cc: PPC list <[email protected]>
Cc: Eric Dumazet <[email protected]>

=20
Poonam,
=20
Can you comment on this patch, does it look correct? =20
- k
=20

Quoted 33 lines
arch/powerpc/boot/dts/p1010si.dtsi +0 -6
index 7f51104..91566aa 100644
@@ -258,8 +258,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;
 

@@ -280,8 +278,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;
 

@@ -302,8 +298,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;
Quoted 4 lines

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

=20

#3 lore raw
Quoted 7 lines · On Mar 17, 2012, at 12:37 AM, Aggrwal Poonam-B10812 wrote:

Hello Pankaj, Rajan
=20
DO you have any comments on the below patch of gianfar?

Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +0 -2
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;

Have been removed from P1010RDB device tree to avoid a kernel panic. =20

Ah, right.

Quoted 1 line

Kumar, as such I see this is the old dts format. Also in the latest =

sdk tree these properties are defined, not sure it is working on = P1010RDB.

Quoted 1 line

I can check on this and get back.

Mostly, can you check that p1010rdb boots and works w/my next branch.

- k

Quoted 19 lines

=20
=20
Regards
Poonam
=20

Quoted 14 lines

-----Original Message-----
From: Kumar Gala [mailto:[email protected]]
Sent: Friday, March 16, 2012 8:50 PM
To: Aggrwal Poonam-B10812
Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues. =20
=20
On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
=20

Quoted 4 lines

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties defined in the p1010's device tree file, I get a kernel panic very shortly after boot. The failure indicates we are configuring the gianfar.c driver for a queue depth greater than actual. Removing =

the

Quoted 52 lines
Quoted 43 lines
Quoted 6 lines

properties got the problem resolved.
=20

Signed-off-by Robin Holt <[email protected]>

To: U Bhaskar-B22300 <[email protected]>
Cc: PPC list <[email protected]>
Cc: Eric Dumazet <[email protected]>

=20
Poonam,
=20
Can you comment on this patch, does it look correct? =20
- k
=20

Quoted 30 lines

=20

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
index 7f51104..91566aa 100644
@@ -258,8 +258,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
@@ -280,8 +278,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20

arch/powerpc/boot/dts/p1010si.dtsi +0 -2
@@ -302,8 +298,6 @@
 			device_type =3D "network";
 			model =3D "eTSEC";
 			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
Quoted 8 lines
Quoted 7 lines
arch/powerpc/boot/dts/p1010si.dtsi +0 -0
 			local-mac-address =3D [ 00 00 00 00 00 00 ];
 			interrupt-parent =3D <&mpic>;

=20
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

=20

=20