Skip to contentSkip to conversation

class_find_device: fix reference to argument "match"

Doc NAK Rolf Eike Beer 4 participants 4 messages Aug 21, 2011 – Aug 23, 2011 Driver core

lore
Share & tools
lore

Rolf Eike Beer

author
#0 lore raw
Signed-off-by Rolf Eike Beer <[email protected]>
---
 drivers/base/class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/base/class.c +1 -1
index 4f1df2e..5bd577b 100644
@@ -403,7 +403,7 @@ EXPORT_SYMBOL_GPL(class_for_each_device);
  *
  * Note, you will need to drop the reference with put_device() after use.
  *
- * @fn is allowed to do anything including calling back into class
+ * @match is allowed to do anything including calling back into class
  * code.  There's no locking restriction.
  */
 struct device *class_find_device(struct class *class, struct device *start,
Signature · 1 line
1.7.6
NAK
#1 lore raw

Re: [Doc] class_find_device: fix reference to argument

Quoted 7 lines · Rolf Eike Beer <eike <at> sf-mail.de> writes:
Signed-off-by Rolf Eike Beer <eike-kernel <at> sf-tec.de>
---
 drivers/base/class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 5 lines

- * @fn is allowed to do anything including calling back into class
+ * @match is allowed to do anything including calling back into class
* code. There's no locking restriction.
*/
struct device *class_find_device(struct class *class, struct device *start,

NACK, it means the function class_find_device but not the @match.

Thanks
-Wanlong Gao

#2 lore raw

Re: [Doc] class_find_device: fix reference to argument

Quoted 9 lines · On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
Quoted 6 lines · Rolf Eike Beer <eike <at> sf-mail.de> writes:
Signed-off-by Rolf Eike Beer <eike-kernel <at> sf-tec.de>
---
 drivers/base/class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 7 lines
Quoted 5 lines

- * @fn is allowed to do anything including calling back into class
+ * @match is allowed to do anything including calling back into class
* code. There's no locking restriction.
*/
struct device *class_find_device(struct class *class, struct device *start,

NACK, it means the function class_find_device but not the @match.

Are you sure? Looks to me like a comment that was copied from class_for_each_device() but shouldn't have been copied.

Anyway, I'll cc: Greg to see if he knows.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#3 lore raw

Re: [Doc] class_find_device: fix reference to argument

Quoted 17 lines · Randy Dunlap
Quoted 15 lines · On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
Quoted 12 lines · Rolf Eike Beer <eike <at> sf-mail.de> writes:
Signed-off-by Rolf Eike Beer <eike-kernel <at> sf-tec.de>
---
 drivers/base/class.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- * @fn is allowed to do anything including calling back into class
+ * @match is allowed to do anything including calling back into class
* code. There's no locking restriction.
*/
struct device *class_find_device(struct class *class, struct device *start,

Quoted 6 lines
Quoted 1 line

NACK, it means the function class_find_device but not the @match.

Are you sure? Looks to me like a comment that was copied from class_for_each_device() but shouldn't have been copied.

Anyway, I'll cc: Greg to see if he knows.

I think the above patch is probably correct, as it can reenter if needed.

thanks,

greg k-h