Skip to contentSkip to conversation

Please back-port git commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9 and 89153b5cae9f40c224a5d321665a97bf14220c2c to 3.0.x

DISCUSSION Konrad Rzeszutek Wilk 3 participants 6 messages Aug 22, 2011 – Sep 6, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank you!

#1 lore raw
Quoted 14 lines · Konrad Rzeszutek Wilk

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

Quoted 7 lines

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank you!

Now queued up.

greg k-h

Acked-by
#2 lore raw
In reply to Konrad Rzeszutek Wilk
Quoted 14 lines · Konrad Rzeszutek Wilk

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

Quoted 7 lines

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank

On a related note having this in stable/longterm (including 2.6.32.y) seems like a good idea? (it was already in the 3.0 baseline)

commit 4352b47ab7918108b389a48d2163c9a4c2aaf139

Author: Marek Marczykowski <[email protected]>
Date:   Tue May 3 12:04:52 2011 -0400

xen-blkfront: fix data size for xenbus_gather in blkfront_connect

barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc).

Ian.

Signature · 4 lines
Ian Campbell
Current Noise: Pestilence - Subordinate To The Domination

It's raisins that make Post Raisin Bran so raisiny ...
#3 lore raw
Quoted 37 lines · Ian Campbell
Quoted 14 lines · Konrad Rzeszutek Wilk

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

Quoted 7 lines

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank

On a related note having this in stable/longterm (including 2.6.32.y) seems like a good idea? (it was already in the 3.0 baseline)

commit 4352b47ab7918108b389a48d2163c9a4c2aaf139

Author: Marek Marczykowski <[email protected]>
Date:   Tue May 3 12:04:52 2011 -0400

xen-blkfront: fix data size for xenbus_gather in blkfront_connect

barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc).

Quoted 4 lines

It might, but it doesn't seem to apply to the .32 or .33-longterm kernels at all, so I would need a backported version to be able to apply it successfully.

thanks,

greg k-h

Acked-by
#4 lore raw
Quoted 38 lines · Greg KH
Quoted 37 lines · Ian Campbell
Quoted 14 lines · Konrad Rzeszutek Wilk

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

Quoted 7 lines

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank

On a related note having this in stable/longterm (including 2.6.32.y) seems like a good idea? (it was already in the 3.0 baseline)

commit 4352b47ab7918108b389a48d2163c9a4c2aaf139

Author: Marek Marczykowski <[email protected]>
Date:   Tue May 3 12:04:52 2011 -0400

xen-blkfront: fix data size for xenbus_gather in blkfront_connect

barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc).

Quoted 8 lines
Quoted 4 lines

It might, but it doesn't seem to apply to the .32 or .33-longterm kernels at all, so I would need a backported version to be able to apply it successfully.

This seems to do the trick.

Ian.

From 2a98f42bfd3308e429b6f03b3e5bce43b11bded8 Mon Sep 17 00:00:00 2001
From: Marek Marczykowski <[email protected]>
Date: Tue, 3 May 2011 12:04:52 -0400
Subject: [PATCH] xen-blkfront: fix data size for xenbus_gather in blkfront_connect

barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc).

---
 drivers/block/xen-blkfront.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/xen-blkfront.c +1 -1
index b8578bb..a2e8977 100644
@@ -889,7 +889,7 @@ static void blkfront_connect(struct blkfront_info *info)
 	}
 
 	err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
-			    "feature-barrier", "%lu", &info->feature_barrier,
+			    "feature-barrier", "%d", &info->feature_barrier,
 			    NULL);
 	if (err)
 		info->feature_barrier = 0;
Signature · 9 lines
1.7.2.5


-- 
Ian Campbell


Please don't put a strain on our friendship by asking me to do something
for you.
#5 lore raw
Quoted 44 lines · Ian Campbell
Quoted 43 lines · Greg KH
Quoted 41 lines · Ian Campbell
Quoted 14 lines · Konrad Rzeszutek Wilk

Hey Greg,

I've two patches that are in Linus's upstream kernel, but I neglected to put the [email protected] on them (duh!). Both Fedora and Ubuntu are carrying those two patches - but it would be nice if other distros got them.

The two patches are:

commit 196cfe2ae8fcdc03b3c7d627e7dfe8c0ce7229f9

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:22 2011 +0200

xen-blkfront: Drop name and minor adjustments for emulated scsi devices

Quoted 7 lines

commit 89153b5cae9f40c224a5d321665a97bf14220c2c

Author: Stefan Bader <[email protected]>
Date:   Thu Jul 14 15:30:37 2011 +0200

xen-blkfront: Fix one off warning about name clash

Please back-port them to 3.0.x kernel. Thank

On a related note having this in stable/longterm (including 2.6.32.y) seems like a good idea? (it was already in the 3.0 baseline)

commit 4352b47ab7918108b389a48d2163c9a4c2aaf139

Author: Marek Marczykowski <[email protected]>
Date:   Tue May 3 12:04:52 2011 -0400

xen-blkfront: fix data size for xenbus_gather in blkfront_connect

barrier variable is int, not long. This overflow caused another variable
override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc).

Quoted 5 lines
Quoted 3 lines

It might, but it doesn't seem to apply to the .32 or .33-longterm kernels at all, so I would need a backported version to be able to apply it successfully.

This seems to do the trick.

Thanks, that worked, now queued up.

greg k-h